git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] Documentation: config: typo fixed
@ 2014-12-18 11:27 Alexander Kuleshov
  2014-12-18 11:30 ` Alexander Kuleshov
  2014-12-18 13:40 ` Matthieu Moy
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Kuleshov @ 2014-12-18 11:27 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, 0xAX

From: 0xAX <kuleshovmail@gmail.com>

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 Documentation/config.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index f615a5c..a995b68 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -203,7 +203,7 @@ advice.*::
 		show directions on how to proceed from the current state.
 --
 
-core.fileMode::
+core.filemode::
 	Tells Git if the executable bit of files in the working tree
 	is to be honored.
 +
-- 
2.2.0.64.g3889e7a.dirty

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/1] Documentation: config: typo fixed
  2014-12-18 11:27 [PATCH 1/1] Documentation: config: typo fixed Alexander Kuleshov
@ 2014-12-18 11:30 ` Alexander Kuleshov
  2014-12-18 13:40 ` Matthieu Moy
  1 sibling, 0 replies; 4+ messages in thread
From: Alexander Kuleshov @ 2014-12-18 11:30 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Alexander Kuleshov

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 Documentation/config.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index f615a5c..a995b68 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -203,7 +203,7 @@ advice.*::
 		show directions on how to proceed from the current state.
 --
 
-core.fileMode::
+core.filemode::
 	Tells Git if the executable bit of files in the working tree
 	is to be honored.
 +
-- 
2.2.0.64.g3889e7a.dirty

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Documentation: config: typo fixed
  2014-12-18 11:27 [PATCH 1/1] Documentation: config: typo fixed Alexander Kuleshov
  2014-12-18 11:30 ` Alexander Kuleshov
@ 2014-12-18 13:40 ` Matthieu Moy
  2014-12-18 14:03   ` Alexander Kuleshov
  1 sibling, 1 reply; 4+ messages in thread
From: Matthieu Moy @ 2014-12-18 13:40 UTC (permalink / raw)
  To: Alexander Kuleshov; +Cc: Junio C Hamano, git

Alexander Kuleshov <kuleshovmail@gmail.com> writes:

> -core.fileMode::
> +core.filemode::
>  	Tells Git if the executable bit of files in the working tree
>  	is to be honored.

I do not think that this is a good change: config variable names are
case insensitive, so filemode and fileMode are both correct. The
convention used elsewhere in the documentation is CamelCasing, so the
old version seems better to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Documentation: config: typo fixed
  2014-12-18 13:40 ` Matthieu Moy
@ 2014-12-18 14:03   ` Alexander Kuleshov
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Kuleshov @ 2014-12-18 14:03 UTC (permalink / raw)
  To: Matthieu Moy; +Cc: Junio C Hamano, git@vger.kernel.org

Ah, yes, didn't know about:

>config variable names are case insensitive

so, you're right, thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-18 14:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-18 11:27 [PATCH 1/1] Documentation: config: typo fixed Alexander Kuleshov
2014-12-18 11:30 ` Alexander Kuleshov
2014-12-18 13:40 ` Matthieu Moy
2014-12-18 14:03   ` Alexander Kuleshov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).