From: "Jakub Narębski" <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Perl <th.perl@gmail.com>, git@vger.kernel.org
Subject: Re: [BUG] gitweb generates wrong links in grep search results (git_search_files)
Date: Wed, 4 Jan 2012 17:21:25 +0100 [thread overview]
Message-ID: <CANQwDwfnp167Uth5TLbCD6OR-Xe6JD-2vENiJVnipi1YdjnMPQ@mail.gmail.com> (raw)
In-Reply-To: <7vhb0cqpix.fsf@alter.siamese.dyndns.org>
On Wed, Jan 4, 2012 at 1:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Thomas Perl <th.perl@gmail.com> writes:
>
>> I think I found a bug in gitweb when grep'ing for text in a branch
>> different from "master". Here's how to reproduce it:
>
> Thanks for a detailed report (and thanks for gpodder ;-).
>
> Jakub, care to take a look?
I see the bug: it should be 'hash_base' not 'hash' in href()
creating link to "blob" view in git_search_files().
I'll try to send a fix soon...
--
Jakub Narebski
next prev parent reply other threads:[~2012-01-04 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 13:29 [BUG] gitweb generates wrong links in grep search results (git_search_files) Thomas Perl
2012-01-04 0:28 ` Junio C Hamano
2012-01-04 16:21 ` Jakub Narębski [this message]
2012-01-05 20:26 ` [PATCH 1/2] gitweb: Fix file links in "grep" search Jakub Narebski
2012-01-05 20:32 ` [PATCH 2/2] gitweb: Harden "grep" search against filenames with ':' Jakub Narebski
2012-01-13 14:09 ` [PATCH 1/2] gitweb: Fix file links in "grep" search Thomas Perl
2012-01-13 19:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANQwDwfnp167Uth5TLbCD6OR-Xe6JD-2vENiJVnipi1YdjnMPQ@mail.gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=th.perl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).