From: Jiang Xin <worldhello.net@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] clean: remove unused variable buf
Date: Sat, 30 May 2015 23:20:52 +0800 [thread overview]
Message-ID: <CANYiYbEYLGZ00RadktTvEY1cp97ZckkUz++dxi6X7FzyrSn2bg@mail.gmail.com> (raw)
In-Reply-To: <555BB586.8050503@web.de>
2015-05-20 6:13 GMT+08:00 René Scharfe <l.s.r@web.de>:
> It had never been used.
Confirmed. The unused "buf" should be removed.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> builtin/clean.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 98c103f..a9eb772 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
> {
> struct string_list menu_list = STRING_LIST_INIT_DUP;
> struct strbuf menu = STRBUF_INIT;
> - struct strbuf buf = STRBUF_INIT;
> struct menu_item *menu_item;
> struct string_list_item *string_list_item;
> int i;
> @@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
> pretty_print_menus(&menu_list);
>
> strbuf_release(&menu);
> - strbuf_release(&buf);
> string_list_clear(&menu_list, 0);
> }
>
> --
> 2.4.1
>
--
Jiang Xin
prev parent reply other threads:[~2015-05-30 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 22:13 [PATCH] clean: remove unused variable buf René Scharfe
2015-05-30 15:20 ` Jiang Xin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANYiYbEYLGZ00RadktTvEY1cp97ZckkUz++dxi6X7FzyrSn2bg@mail.gmail.com \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).