* [PATCH] clean: remove unused variable buf
@ 2015-05-19 22:13 René Scharfe
2015-05-30 15:20 ` Jiang Xin
0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2015-05-19 22:13 UTC (permalink / raw)
To: Git Mailing List; +Cc: Jiang Xin, Junio C Hamano
It had never been used.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
builtin/clean.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/builtin/clean.c b/builtin/clean.c
index 98c103f..a9eb772 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
{
struct string_list menu_list = STRING_LIST_INIT_DUP;
struct strbuf menu = STRBUF_INIT;
- struct strbuf buf = STRBUF_INIT;
struct menu_item *menu_item;
struct string_list_item *string_list_item;
int i;
@@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
pretty_print_menus(&menu_list);
strbuf_release(&menu);
- strbuf_release(&buf);
string_list_clear(&menu_list, 0);
}
--
2.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clean: remove unused variable buf
2015-05-19 22:13 [PATCH] clean: remove unused variable buf René Scharfe
@ 2015-05-30 15:20 ` Jiang Xin
0 siblings, 0 replies; 2+ messages in thread
From: Jiang Xin @ 2015-05-30 15:20 UTC (permalink / raw)
To: René Scharfe; +Cc: Git Mailing List, Junio C Hamano
2015-05-20 6:13 GMT+08:00 René Scharfe <l.s.r@web.de>:
> It had never been used.
Confirmed. The unused "buf" should be removed.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> builtin/clean.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 98c103f..a9eb772 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -314,7 +314,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
> {
> struct string_list menu_list = STRING_LIST_INIT_DUP;
> struct strbuf menu = STRBUF_INIT;
> - struct strbuf buf = STRBUF_INIT;
> struct menu_item *menu_item;
> struct string_list_item *string_list_item;
> int i;
> @@ -363,7 +362,6 @@ static void print_highlight_menu_stuff(struct menu_stuff *stuff, int **chosen)
> pretty_print_menus(&menu_list);
>
> strbuf_release(&menu);
> - strbuf_release(&buf);
> string_list_clear(&menu_list, 0);
> }
>
> --
> 2.4.1
>
--
Jiang Xin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-30 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 22:13 [PATCH] clean: remove unused variable buf René Scharfe
2015-05-30 15:20 ` Jiang Xin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).