From: Jiang Xin <worldhello.net@gmail.com>
To: Harring Figueiredo <harringf@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: pt_BR initializaton
Date: Sun, 10 Mar 2013 17:12:43 +0800 [thread overview]
Message-ID: <CANYiYbG1hqRCmUD=J4xMe8GPk8Uu4+Vb+b30e-tySPWE7JPo8Q@mail.gmail.com> (raw)
In-Reply-To: <CAN_hzmot2vHRYeZWaoh=pbeoG3RNvzsKkUv+9jVs4WUU74tkbg@mail.gmail.com>
Hi Harring,
I'm glad to see that there will be another locale for Git.
I reviewed three commit from you. There are some problems:
Because git has a strict and high standard for commit log, so
1. your commit log must have "Signed-off-by: " line(s).
Commit using "commit -s", or using alias such as
"git config --global alias.ci 'commit -s'" may help.
Such line(s) are signatures of reviewers and contributors for
your commit, and these line(s) are ordered by the time of
contributions.
2. 50+72 rule.
The first line of your commit should no longer than 50
characters, and should not contain characters other than
standard ascii characters. This is because when your
commit save as patch file using git format-patch, first line
of your commit will be used as filename, and as email
subject.
Then a blank line to separate subject and other contents
if there are any other descriptions for your commit.
Other lines in your commit log messages should be
wrapped at line 72 or less, and you can use unicode
characters.
3. Add "l10n:" prefix in subject of your commit log messages.
You can find out how other l10n contributors writing
there commit log message, using this command:
git log -- po/
4. Squash trivial commits before send to upstream.
If you find it is hard to write your commit log message,
it may indicate that you have make too many trivial
commits. In this case, you should squash your commit
before send them to upstream using "git rebase -i
--autosquash" command.
Tips: trivial commit (for backup or fixup previous commit)
may commit using "--fixup" or "--squash" option, such as:
git commit --fixup HEAD
and these commits will be squash automatically when:
git rebase -i --autosquash
There is a script in po-helper branch, and I use it to check
commits from other l10n contributors, and it may also help
for you:
https://github.com/git-l10n/git-po/blob/po-helper/po/po-helper.sh
This discussion may also help:
http://article.gmane.org/gmane.comp.version-control.git/198626
2013/3/10 Harring Figueiredo <harringf@gmail.com>:
>
>
> Hello Jiang,
>
> Please pull the changes from https://github.com/harringf/git-po.git to
> initialize the pt_BR translation.
>
> Thank you,
>
> Harring Figueiredo
--
Jiang Xin
parent reply other threads:[~2013-03-10 9:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAN_hzmot2vHRYeZWaoh=pbeoG3RNvzsKkUv+9jVs4WUU74tkbg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANYiYbG1hqRCmUD=J4xMe8GPk8Uu4+Vb+b30e-tySPWE7JPo8Q@mail.gmail.com' \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=harringf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).