Re: [PATCH v6 13/16] commit-graph: new Bloom filter version that fixes murmur3

[Jiang Xin <worldhello.net@gmail.com>]

On Thu, Feb 1, 2024 at 9:50 AM Taylor Blau <me@ttaylorr.com> wrote:
>
> diff --git a/Documentation/config/commitgraph.txt b/Documentation/config/commitgraph.txt
> index e68cdededa..7f8c9d6638 100644
> --- a/Documentation/config/commitgraph.txt
> +++ b/Documentation/config/commitgraph.txt
> @@ -15,7 +15,7 @@ commitGraph.readChangedPaths::
>
>  commitGraph.changedPathsVersion::

The word commitGraph is in camelCase here.

> diff --git a/commit-graph.c b/commit-graph.c
> index 6c3fbae142..6f9cab181e 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -2501,6 +2499,13 @@ int write_commit_graph(struct object_directory *odb,
>         }
>         if (!commit_graph_compatible(r))
>                 return 0;
> +       if (r->settings.commit_graph_changed_paths_version < -1
> +           || r->settings.commit_graph_changed_paths_version > 2) {
> +               warning(_("attempting to write a commit-graph, but "
> +                         "'commitgraph.changedPathsVersion' (%d) is not supported"),

To fix mismatched config variable, s/commitgraph/commitGraph/
See: https://github.com/git-l10n/pot-changes/blob/pot/seen/2024-02-27.diff#L32

--
Jiang Xin