From: Jiang Xin <worldhello.net@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð" <avarab@gmail.com>,
"Nguyễn Thái Ngọc" <pclouds@gmail.com>,
"Stefano Lattarini" <stefano.lattarini@gmail.com>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>
Subject: Re: [PATCH v4 2/7] i18n: rebase: mark strings for translation
Date: Wed, 25 Jul 2012 15:32:14 +0800 [thread overview]
Message-ID: <CANYiYbHnv0JppT64cnjzBgRq7_pRFHN5WMy2SAVj2GzG+dWBaA@mail.gmail.com> (raw)
In-Reply-To: <20120725042134.GA3055@burratino>
2012/7/25 Jonathan Nieder <jrnieder@gmail.com>:
> I haven't tested or reviewed this patch in detail, so even though it
> looks good, I'd prefer it not to have my Reviewed-by. (See
> Documentation/SubmittingPatches: '"Reviewed-by:", unlike the other
> extra tags, can only be offered by the reviewer'.) If you'd like to
> credit my help, something like "With advice from Jonathan." would be
> fine.
How about Acked-by: ?
--
Jiang Xin
next prev parent reply other threads:[~2012-07-25 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:53 [PATCH v4 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 3:53 ` [PATCH v4 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 3:53 ` [PATCH v4 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-25 3:53 ` [PATCH v4 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-25 3:53 ` [PATCH v4 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25 3:53 ` [PATCH v4 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25 3:53 ` [PATCH v4 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-25 3:53 ` [PATCH v4 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-25 4:30 ` [PATCH v4 6/7] Remove dead code which contains bad gettext block Jonathan Nieder
2012-07-25 4:26 ` [PATCH v4 5/7] i18n: am: mark more strings for translation Jonathan Nieder
2012-07-25 9:59 ` Stefano Lattarini
2012-07-25 11:01 ` Jiang Xin
2012-07-25 4:21 ` [PATCH v4 2/7] i18n: rebase: mark " Jonathan Nieder
2012-07-25 7:32 ` Jiang Xin [this message]
2012-07-25 9:56 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANYiYbHnv0JppT64cnjzBgRq7_pRFHN5WMy2SAVj2GzG+dWBaA@mail.gmail.com \
--to=worldhello.net@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=pclouds@gmail.com \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).