Re: [GSoC] Git Blog 4

[ZheNing Hu <adlternative@gmail.com>]

ZheNing Hu <adlternative@gmail.com> 于2021年6月15日周二 下午4:59写道：
>
> >
> > In the cover letter of your patch series you say:
> >
> > "There is still an unresolved issue: performance overhead is very large, so
> > that when we use:
> >
> > git cat-file --batch --batch-all-objects >/dev/null
> >
> > on git.git, it may fail."
> >
> > Is this the same issue? Is it only a memory issue, or is your patch
> > series also making things slower?
> >
>
> Yes, they are talking about the same thing, the memory usage is too large.
> Of course I should check for memory leaks first. However, this is mainly
> caused by changes in the strategy of cat-file printing object data.
>

In fact, it is indeed a problem caused by a memory leak: batch_object_write()
forget to free the ref_array_item->value. After solving the problem, although
the performance of `git cat-file --batch-all-objects --batch` is still poor, at
least there will be no triggering the oom killer.

--
ZheNing Hu