Re: [GSoC][RFC][Proposal] Unify ref filters in pretty.{c,h}

[ZheNing Hu <adlternative@gmail.com>]

Hariom verma <hariom18599@gmail.com> 于2022年4月20日周三 02:23写道：
>
> On Mon, Apr 18, 2022 at 11:13 PM Kaartic Sivaraam
> <kaartic.sivaraam@gmail.com> wrote:
> >
> > +Cc: Christian, Hariom
> >
>
> Thanks Kaartic.
>
> > > ===============
> > > View in Google Docs:
> > > https://docs.google.com/document/d/1qq-Xze6dMGMSx3rPHD0VEc4f0a87KnHgbka1Dzpf8sc/edit?usp=sharing
> > > ===============
> > > Proposal
> > > ===============
> > >
> > > Unify ref-filters with other pretty formats.
> > >
> > > Name          :       Jaydeep Prapanch Das
> > > Email         :       jaydeepjd.8914@gmail.com
> > > Contact               :       +91 6026139802
> > > Github                :       JDeepD(https://github.com/JDeepD)
> > > Linkedin      :       https://www.linkedin.com/in/jdeepd
> > > Course                :       Computer Science and Engineering, 2025
> > > Time Zone     :       IST(+5:30)
> > >
> > > ## About me:
> > >
> > > I am a first year undergraduate at National Institute of Technology,
> > > Silchar  pursuing B.Tech in Computer Science and Engineering. My
> > > interests include FOSS development, Data Science and Robotics. I have
> > > been writing Python, C and shell scripts for about 3 years now. Apart
> > > from that I also blog[1] whenever I find an interesting topic to blog
> > > about. During the GSoC period I also plan to blog about the new things
> > > in git that I hope to learn.
> > >
> > > [1]: https://jdeep.me/
> > >
> > > ## Micro-Project:
> > >
> > > I am still a newbie in git development and made my first (minor)
> > > contribution in Feb 2022 [1]. This was a patch I made just to get
> > > familiar with the patching and sending patches to the mailing list. For
> > > my micro project, I worked on adding diff driver for the Kotlin language.[2]
> > > The main objective was to make an xfuncname regex which matches keywords
> > > in Kotlin syntax so that they are considered as a single token
> > > whenever diffs are generated. Along with that, a word_regex regex pattern
> > > was also needed so that variable names, compound operators etc are not
> > > broken into individual tokens by git diff when there is a change in them.
> > > For ex,  if a == b is changed to  a != b , then the diff should show
> > > that entire
> > > `==` token is replaced with the token `!=`. While working on this micro
> > > project, I learned a lot about the contribution and review workflow of
> > > git. It took 7 patches to incorporate all the reviews and suggestions so
> > > yeah, It did require some patience :-).
> > >
> > >
> > > Minor patch(merged in master)
> > > [1]:
> > > https://public-inbox.org/git/20220208092339.651761-2-jaydeepjd.8914@gmail.com/
> > >
> > > Micro Project(merged in master)
> > > [2]:
> > > https://public-inbox.org/git/20220312044832.718356-1-jaydeepjd.8914@gmail.com/
> > >
> > >
> > > ## Proposal:
> > >
> > > Git has an old problem of duplicated implementations of some logic. For
> > > example, Git has at least 4 implementations to format commands for
> > > different commands. Previously, Olga Telezhnaya[1] and Hariom Verma[2]
> > > worked on this and eliminated most of the duplicate logic. But still,
> > > there are still some things left to do. Current task is to reuse
> > > ref-filter logic in pretty.
>
> Can you provide more details on what has been done? And what’s still left?
>
> ZheNing Hu also worked on "Use ref-filter formats in git cat-file"
> last year, maybe you can include that too.
>
>

Hi, maybe I can give some helps. I am thinking about this project occasionally
a few months. Due to the performance of the ref-filter, me, Olga, Hariom, our
patches doesn't merge to master branch.

So we'd better think of ways to improve the performance of the ref-filter.
I think there needs to be a huge refactoring here.

> Thanks,
> Hariom

Thanks.
--
ZheNing Hu