From: Karthik Nayak <karthik.188@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH v6 01/11] ref-filter: use string_list_split over strbuf_split
Date: Thu, 18 Feb 2016 19:49:28 +0530 [thread overview]
Message-ID: <CAOLa=ZR3XRuYBG4Pm0okS6TG3k9tEGwc-EvKq1As0CLCU4i3rQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq1t8bhtdw.fsf@gitster.mtv.corp.google.com>
On Thu, Feb 18, 2016 at 3:49 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote:
>>
>>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>>> > From: Jeff King <peff@peff.net>
>>> >
>>> > We don't do any post-processing on the resulting strbufs, so it is
>>> > simpler to just use string_list_split, which takes care of removing
>>> > the delimiter for us.
>>> >
>>> > Written-by: Jeff King <peff@peff.net>
>>>
>>> Perhaps Peff can give his sign-off...
>>
>> Ah, right. I usually sign-off when sending to the list, so the version
>> he pulled from GitHub didn't have it.
>>
>> Definitely:
>>
>> Signed-off-by: Jeff King <peff@peff.net>
>>
>> And I don't think "Written-by" was doing much here, anyway; I am already
>> the author by the From header at the top. :)
>
> ;-).
>
> So, is everybody happy with this round?
>
> With another series on top for the "conditional" stuff, I guess we
> are ready to do the formatting for "git branch --list", which would
> be a big step forward.
>
> Thanks.
Yes, I'll be sending that soon :D
> Yes, v6 looks good to me and is:
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
> I have not looked with nearly as close an eye as Eric, but I did not see
> anything objectionable (and I trust the reviews that have led us up to
> v6 in the first place).
>
> Thanks, Karthik, for your continued work on this (and to reviewers, of
> course :) ).
>
> -Peff
Thanks to everyone who helped, especially reviewers for going through such
long patch series.
--
Regards,
Karthik Nayak
next prev parent reply other threads:[~2016-02-18 14:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:06 [PATCH v6 00/11] ref-filter: use parsing functions Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 01/11] ref-filter: use string_list_split over strbuf_split Karthik Nayak
2016-02-17 22:11 ` Eric Sunshine
2016-02-17 22:14 ` Jeff King
2016-02-17 22:19 ` Junio C Hamano
2016-02-17 22:21 ` Eric Sunshine
2016-02-17 22:26 ` Jeff King
2016-02-18 14:19 ` Karthik Nayak [this message]
2016-02-17 18:06 ` [PATCH v6 02/11] ref-filter: bump 'used_atom' and related code to the top Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 03/11] ref-filter: introduce struct used_atom Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 04/11] ref-filter: introduce parsing functions for each valid atom Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 05/11] ref-filter: introduce color_atom_parser() Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 06/11] ref-filter: introduce parse_align_position() Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 07/11] ref-filter: introduce align_atom_parser() Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 08/11] ref-filter: align: introduce long-form syntax Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 09/11] ref-filter: introduce remote_ref_atom_parser() Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 10/11] ref-filter: introduce contents_atom_parser() Karthik Nayak
2016-02-17 18:06 ` [PATCH v6 11/11] ref-filter: introduce objectname_atom_parser() Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZR3XRuYBG4Pm0okS6TG3k9tEGwc-EvKq1As0CLCU4i3rQ@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).