From: Karthik Nayak <karthik.188@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH v2] reftable/stack: adjust permissions of compacted tables
Date: Thu, 25 Jan 2024 13:05:37 +0000 [thread overview]
Message-ID: <CAOLa=ZSDRr8v0uo2aCtdnbv0F=cFMQymnNLMTzpUt-OCdh5NMA@mail.gmail.com> (raw)
In-Reply-To: <b2fb6f5ad0c558527341bd8040544d6b0ae5d8a2.1706100744.git.ps@pks.im>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Patrick Steinhardt <ps@pks.im> writes:
> When creating a new compacted table from a range of preexisting ones we
> don't set the default permissions on the resulting table when specified
> by the user. This has the effect that the "core.sharedRepository" config
> will not be honored correctly.
>
> Fix this bug and add a test to catch this issue.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>
> Ugh, I totally forgot about the fact that fchmod(3P) isn't actually
> available on Windows. I've thus evicted the first patch and changed the
> second patch to use chmod(3P) instead. Too bad.
>
Good catch. This version looks good to me! Nothing to add :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 690 bytes --]
next prev parent reply other threads:[~2024-01-25 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 12:31 [PATCH 0/2] reftable: adjust permissions of compacted tables Patrick Steinhardt
2024-01-24 12:31 ` [PATCH 1/2] reftable/stack: use fchmod(3P) to set permissions Patrick Steinhardt
2024-01-24 12:31 ` [PATCH 2/2] reftable/stack: adjust permissions of compacted tables Patrick Steinhardt
2024-01-24 12:53 ` [PATCH v2] " Patrick Steinhardt
2024-01-25 13:05 ` Karthik Nayak [this message]
2024-01-25 16:02 ` Justin Tobler
2024-01-26 10:05 ` Patrick Steinhardt
2024-01-26 10:09 ` [PATCH v3] " Patrick Steinhardt
2024-01-30 16:56 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZSDRr8v0uo2aCtdnbv0F=cFMQymnNLMTzpUt-OCdh5NMA@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).