From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 5/8] branch: drop non-commit error reporting
Date: Mon, 21 Sep 2015 15:50:31 +0530 [thread overview]
Message-ID: <CAOLa=ZTYfNN6ATae6pYy1QHPo-u70itz9euHvaWjiayUgKD9GA@mail.gmail.com> (raw)
In-Reply-To: <vpq6134gauz.fsf@anie.imag.fr>
On Mon, Sep 21, 2015 at 12:46 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Remove the error reporting variable to make the code easier to port
>> over to using ref-filter APIs. This variable
>
> (it's not just a variable, it's also a message on the output)
>
>> is not required as in ref-filter we already check for possible errors
>> and report them.
>
> You should explain more why the check is redundant with the ones in
> ref-filter. You discussed this with Junio on the last round. The
> arguments you gave would deserve to appear in the commit message IMHO.
> Pointing to the exact checks in ref-filter would help.
>
> It may make sense to split the commit into several smaller ones, so that
> you can give a precise commit message for each error reporting you
> remove (error(_("branch '%s' does not point at a commit") and
> error(_("some refs could not be read"))).
>
I could do that, but it would be small changes. But I think it's worth it,
will wait for other changes if needed and send.
--
Regards,
Karthik Nayak
next prev parent reply other threads:[~2015-09-21 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 18:10 [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 1/8] branch: refactor width computation Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 2/8] branch: bump get_head_description() to the top Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 3/8] branch: roll show_detached HEAD into regular ref_list Karthik Nayak
2015-09-20 19:11 ` Matthieu Moy
2015-09-20 18:10 ` [PATCH v5 4/8] branch: move 'current' check down to the presentation layer Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 5/8] branch: drop non-commit error reporting Karthik Nayak
2015-09-20 19:16 ` Matthieu Moy
2015-09-21 10:20 ` Karthik Nayak [this message]
2015-09-21 11:35 ` Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 6/8] branch.c: use 'ref-filter' data structures Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 7/8] branch.c: use 'ref-filter' APIs Karthik Nayak
2015-09-20 19:24 ` Matthieu Moy
2015-09-21 10:21 ` Karthik Nayak
2015-09-20 18:10 ` [PATCH v5 8/8] branch: add '--points-at' option Karthik Nayak
2015-09-20 19:00 ` [PATCH v5 0/8] port the filtering part of branch.c to use ref-filter APIs Matthieu Moy
2015-09-21 6:11 ` Karthik Nayak
2015-09-21 6:23 ` Matthieu Moy
2015-09-21 10:15 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZTYfNN6ATae6pYy1QHPo-u70itz9euHvaWjiayUgKD9GA@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).