From: Vitor Antunes <vitor.hda@gmail.com>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>
Subject: Re: [PATCH/RFC 2/2] git-p4: Add complex test case for branch import
Date: Wed, 24 Aug 2011 11:46:53 +0100 [thread overview]
Message-ID: <CAOpHH-V9nm2NRD47gdUj6sLJSTypjABjE-JGCkADE=fxh2nSWg@mail.gmail.com> (raw)
In-Reply-To: <20110823231034.GA11918@arf.padd.com>
On Wed, Aug 24, 2011 at 12:10 AM, Pete Wyckoff <pw@padd.com> wrote:
> Nice analysis. P4 can indeed be the bottleneck, even on near
> servers if there are lots of files. Diff-tree seems like the
> better choice to find the branch point. I don't understand fully
> why the way we are using fast-import causes these problems. Will
> look at that next.
I came up with some ideas during sleep:
1. When doing a "checkpoint" it would make sense to have some kind of
feedback loop to know when fast-import completes it. In fact, I've
just looked at fast-import man page and the "progress" command seems
to do exactly that! Myabe we should crease a specific function for
"checkpoint" that would call also "progress" instead of calling
os.sleep().
2. In order to avoid needing to use "--force" it would be nice to have
some form of "drop" command in fast-import that would allows us to
actively drop an older commit after calling "reset" (this could even
be an option of "reset"). This way fast-import would not find
dangling commits in the end of the import. Maybe there's already
some sort of command to achieve this in fast-import...? We could
probably ask to one of its maintainers.
--
Vitor Antunes
next prev parent reply other threads:[~2011-08-24 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 0:09 [PATCH/RFC 0/2] Search for parent commit in new branch import Vitor Antunes
2011-08-19 0:09 ` [PATCH/RFC 1/2] git-p4: Search for parent commit on branch creation Vitor Antunes
2011-08-19 0:09 ` [PATCH/RFC 2/2] git-p4: Add complex test case for branch import Vitor Antunes
2011-08-20 19:12 ` Pete Wyckoff
2011-08-22 0:13 ` Vitor Antunes
2011-08-23 2:27 ` Pete Wyckoff
2011-08-23 22:02 ` Vitor Antunes
2011-08-23 23:10 ` Pete Wyckoff
2011-08-24 10:46 ` Vitor Antunes [this message]
2011-08-24 21:23 ` Vitor Antunes
2011-08-27 23:32 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOpHH-V9nm2NRD47gdUj6sLJSTypjABjE-JGCkADE=fxh2nSWg@mail.gmail.com' \
--to=vitor.hda@gmail.com \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).