git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] rebase: pass --signoff option to git am
Date: Thu, 26 Jan 2017 19:18:31 +0100	[thread overview]
Message-ID: <CAOxFTcx1NsBfiSqQgomE5USsd0DBKtQZPQEJgnpphTRWrUn=ow@mail.gmail.com> (raw)
In-Reply-To: <CAOxFTcyuLkvgPOxQuzaDUVuDRu_KJg=JrYtU84pQyjLstChbLg@mail.gmail.com>

On Mon, Jan 23, 2017 at 9:03 PM, Giuseppe Bilotta
<giuseppe.bilotta@gmail.com> wrote:
> On Mon, Jan 23, 2017 at 7:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Should we plan to extend this to the interactive backend that is
>> shared between rebase -i and rebase -m, too?  Or is this patch
>> already sufficient to cover them?
>
> AFAIK this is sufficient for both, in the sense that I've used it with
> git rebase -i and it works.

Hm, something very strange is going on, I've just tested the patch on
top of current next and for some reason the signoff line does not get
added. The command-line option gets passed to git am, but I get no
signoff for some reason, so something is failing down the line, I'll
have to investigate.

-- 
Giuseppe "Oblomov" Bilotta

  parent reply	other threads:[~2017-01-26 18:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 10:49 [PATCH] rebase: pass --signoff option to git am Giuseppe Bilotta
2017-01-23 18:13 ` Junio C Hamano
2017-01-23 20:03   ` Giuseppe Bilotta
2017-01-23 20:16     ` Junio C Hamano
2017-01-23 22:35       ` Giuseppe Bilotta
2017-01-23 23:27         ` Junio C Hamano
2017-01-24  7:06           ` Giuseppe Bilotta
2017-01-26 18:18     ` Giuseppe Bilotta [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-11-27 11:15 Giuseppe Bilotta
2010-11-28  0:32 ` Sverre Rabbelier
2010-11-27 19:05   ` Martin von Zweigbergk
2010-11-28  8:00     ` Giuseppe Bilotta
2010-11-29 22:57 ` Kevin Ballard
2010-11-30  8:09   ` Giuseppe Bilotta
2010-12-06 10:41     ` Giuseppe Bilotta
2010-12-06 17:28       ` Jonathan Nieder
2010-09-16  9:07 Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOxFTcx1NsBfiSqQgomE5USsd0DBKtQZPQEJgnpphTRWrUn=ow@mail.gmail.com' \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).