From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Git List <git@vger.kernel.org>
Subject: Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables
Date: Fri, 4 Sep 2015 23:10:52 +0200 [thread overview]
Message-ID: <CAOxFTczPD00rw3nmaYjM=afXez_07p8kM28XY__opLKsVOaWxg@mail.gmail.com> (raw)
In-Reply-To: <xmqqpp1yf3qe.fsf@gitster.mtv.corp.google.com>
On Fri, Sep 4, 2015 at 8:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> It shouldn't be necessary for $GIT_DIR, but it makes sense for other git
>> variables. E.g., with "AcceptEnv GIT_*", "git -c" config is propagated.
>> E.g.:
>> ...
>
> Just to make sure I got you correctly, you are saying that "we
> propagate, but that is not correct. We should stop doing so", right?
Indeed, we should not propagate them. For what we know so far, at
least GIT_DIR and GIT_WORK_TREE should be removed from the ssh
environment, in case the remote server has AcceptEnv GIT_* and an
older git version.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2015-09-04 21:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 10:52 [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables Giuseppe Bilotta
2015-09-04 12:54 ` Jeff King
2015-09-04 14:02 ` Giuseppe Bilotta
2015-09-04 14:26 ` Jeff King
2015-09-04 18:18 ` Junio C Hamano
2015-09-04 21:10 ` Giuseppe Bilotta [this message]
2015-09-04 21:44 ` Jeff King
2015-09-04 22:40 ` [PATCH] git_connect: clear GIT_* environment for ssh Jeff King
2015-09-05 13:50 ` Giuseppe Bilotta
2015-09-08 8:33 ` [PATCH] git_connect: clarify conn->use_shell flag Jeff King
2015-09-08 17:18 ` Junio C Hamano
2015-09-08 21:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOxFTczPD00rw3nmaYjM=afXez_07p8kM28XY__opLKsVOaWxg@mail.gmail.com' \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).