Incorrect v1.7.10.4 tag on github?

Incorrect v1.7.10.4 tag on github?

[Graham Ballantyne]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

I just downloaded the 1.7.10.4 tag from github. After compiling and installing, git --version returns "git version 1.7.10.3". I think that tag might be pointing to the wrong commit? 

-- 
Graham Ballantyne
grahamb@sfu.ca

IT Services
Simon Fraser University
Burnaby, BC  V5A 1S6
www.sfu.ca/itservices


Sponsor me in the Ride to Conquer Cancer -- 300km from Vancouver to Seattle.
http://conquercancer.ca/goto/grahamballantyne


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 1807 bytes --]

Re: Incorrect v1.7.10.4 tag on github?

[Jeff King]

On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:

> I just downloaded the 1.7.10.4 tag from github. After compiling and
> installing, git --version returns "git version 1.7.10.3". I think that
> tag might be pointing to the wrong commit?

Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR
in GIT-VERSION-GEN. Operator error from the maintainer?

It builds with the right version from the git repository (which runs
git-describe and sees we are on the v1.7.10.4 tag), but exporting the
tag's contents and building fails. I suspect that the git-1.7.10.4
tarball on kernel.org would also have the same problem.

-Peff

Re: Incorrect v1.7.10.4 tag on github?

[Junio C Hamano]

Jeff King <peff@peff.net> writes:

> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:
>
>> I just downloaded the 1.7.10.4 tag from github. After compiling and
>> installing, git --version returns "git version 1.7.10.3". I think that
>> tag might be pointing to the wrong commit?
>
> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR
> in GIT-VERSION-GEN. Operator error from the maintainer?

Thanks for noticing.

> It builds with the right version from the git repository (which runs
> git-describe and sees we are on the v1.7.10.4 tag), but exporting the
> tag's contents and building fails. I suspect that the git-1.7.10.4
> tarball on kernel.org would also have the same problem.

It builds correctly if you download the tarball from the official
location in the [ANNOUNCE] message.  This is because the build
procedure for the official tarball does a bit more than just running
"git archive-tar", which is what gitweb download interface does
(namely, it adds the correct "version" file).

Re: Incorrect v1.7.10.4 tag on github?

[Jeff King]

On Fri, Jun 15, 2012 at 12:14:18PM -0700, Junio C Hamano wrote:

> > It builds with the right version from the git repository (which runs
> > git-describe and sees we are on the v1.7.10.4 tag), but exporting the
> > tag's contents and building fails. I suspect that the git-1.7.10.4
> > tarball on kernel.org would also have the same problem.
> 
> It builds correctly if you download the tarball from the official
> location in the [ANNOUNCE] message.  This is because the build
> procedure for the official tarball does a bit more than just running
> "git archive-tar", which is what gitweb download interface does
> (namely, it adds the correct "version" file).

Thanks. I should have checked before responding. If it is just the
output of "git archive", and the problem is restricted to one version,
then I am not too worried about it. Re-tagging is out of the question,
anyway.

-Peff

Re: Incorrect v1.7.10.4 tag on github?

[Dan Johnson]

On Fri, Jun 15, 2012 at 3:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:
>>
>>> I just downloaded the 1.7.10.4 tag from github. After compiling and
>>> installing, git --version returns "git version 1.7.10.3". I think that
>>> tag might be pointing to the wrong commit?
>>
>> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR
>> in GIT-VERSION-GEN. Operator error from the maintainer?
>
> Thanks for noticing.
>
>> It builds with the right version from the git repository (which runs
>> git-describe and sees we are on the v1.7.10.4 tag), but exporting the
>> tag's contents and building fails. I suspect that the git-1.7.10.4
>> tarball on kernel.org would also have the same problem.
>
> It builds correctly if you download the tarball from the official
> location in the [ANNOUNCE] message.  This is because the build
> procedure for the official tarball does a bit more than just running
> "git archive-tar", which is what gitweb download interface does
> (namely, it adds the correct "version" file).

Junio,
I just noticed that the download buttons (for tarballs) on gitscm.com
all point to the github tag list ( https://github.com/git/git/tags )
instead of the location pointed to by your [ANNOUNCE] message (
http://code.google.com/p/git-core/downloads/list )

If you do something special as part of releasing these tarballs, is
this something that should be corrected? I can look at the source and
do a pull request for gitscm.com a little later, if needed.

-- 
-Dan Johnson

Re: Incorrect v1.7.10.4 tag on github?

[Jeff King]

On Mon, Jul 02, 2012 at 03:52:31PM -0400, Dan Johnson wrote:

> > It builds correctly if you download the tarball from the official
> > location in the [ANNOUNCE] message.  This is because the build
> > procedure for the official tarball does a bit more than just running
> > "git archive-tar", which is what gitweb download interface does
> > (namely, it adds the correct "version" file).
> 
> I just noticed that the download buttons (for tarballs) on gitscm.com
> all point to the github tag list ( https://github.com/git/git/tags )
> instead of the location pointed to by your [ANNOUNCE] message (
> http://code.google.com/p/git-core/downloads/list )

Ick. Yeah, I would think it would definitely want to point to Junio's
built tarballs, because they contain the built 'configure' script.
Otherwise, the downloader would need to have autoconf installed if they
wanted to use configure.

> If you do something special as part of releasing these tarballs, is
> this something that should be corrected? I can look at the source and
> do a pull request for gitscm.com a little later, if needed.

I suspect that the tarballs link on git-scm.com should at the very least
point to:

  http://code.google.com/p/git-core/downloads/list

That list is a little overwhelming because it contains the html and
manpage tarballs, too. It might make sense to provide a cut-down list
(e.g., only source tarballs, and only the latest for each minor version,
and omit -rc candidates for already-released versions). But that would
be a lot more involved.

-Peff

Re: Incorrect v1.7.10.4 tag on github?

[Junio C Hamano]

Dan Johnson <computerdruid@gmail.com> writes:

> Junio,
> I just noticed that the download buttons (for tarballs) on gitscm.com
> all point to the github tag list ( https://github.com/git/git/tags )
> instead of the location pointed to by your [ANNOUNCE] message (
> http://code.google.com/p/git-core/downloads/list )

Thanks for noticing, but what GitHub does is outside my control.
Luckily I see Peff is in the loop so this will hopefully be resolved
shortly ;-).

> If you do something special as part of releasing these tarballs, is
> this something that should be corrected?

I do not do anything special other than "make dist", but obviously
anybody's "list of tags" that drive "git archive" won't run it, so
it is a wrong thing to point at, regardless of who hosts it.

Re: Incorrect v1.7.10.4 tag on github?

[Scott Chacon]

Hey,

On Mon, Jul 2, 2012 at 2:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I just noticed that the download buttons (for tarballs) on gitscm.com
>> all point to the github tag list ( https://github.com/git/git/tags )
>> instead of the location pointed to by your [ANNOUNCE] message (
>> http://code.google.com/p/git-core/downloads/list )
>
>> If you do something special as part of releasing these tarballs, is
>> this something that should be corrected?
>
> I do not do anything special other than "make dist", but obviously
> anybody's "list of tags" that drive "git archive" won't run it, so
> it is a wrong thing to point at, regardless of who hosts it.

Thanks for letting me know - I didn't realize that the built tarballs
were different from the tagged commit trees.  I will update the links.

Scott

Re: Incorrect v1.7.10.4 tag on github?

[Junio C Hamano]

Scott Chacon <schacon@gmail.com> writes:

> Thanks for letting me know - I didn't realize that the built tarballs
> were different from the tagged commit trees.  I will update the links.

Thanks.