From: Ben Walton <bdwalton@gmail.com>
To: Angelo Borsotti <angelo.borsotti@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, git <git@vger.kernel.org>
Subject: Re: git config error message
Date: Sat, 27 Oct 2012 09:45:24 +0100 [thread overview]
Message-ID: <CAP30j15pUwX9sD3FXAfroxFK9paHmb1eAg+M5YAHT4aB22DBEw@mail.gmail.com> (raw)
In-Reply-To: <CAB9Jk9CONVSZvBUgnZHiniwPHHvcap8Wyjyw-sCHaSokDoNRWA@mail.gmail.com>
On Sat, Oct 27, 2012 at 9:32 AM, Angelo Borsotti
<angelo.borsotti@gmail.com> wrote:
Hi Angelo,
> I wrote "value", but I meant "name". The first example I made contains
> a name with a nonexistent section, the second a name with a
> nonexistent key.
This still wouldn't be an error condition though, especially in terms
of how "git config" should treat it. It should be up to the consumer
of the information to display, or not, any error or diagnostics that
don't result from either a bad request (your first case) or a
malformed configuration file. This fits with the callback nature of
how the config file is parsed by builtin tools. The exit code from
"git config" with a missing key is enough for the consumer to make
this decision.
This is just my take on it, but I think the current approach makes sense.
Thanks
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Take the risk of thinking for yourself. Much more happiness,
truth, beauty and wisdom will come to you that way.
-Christopher Hitchens
---------------------------------------------------------------------------------------------------------------------------
next prev parent reply other threads:[~2012-10-27 8:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 8:10 git config error message Angelo Borsotti
2012-10-27 8:25 ` Andreas Schwab
2012-10-27 8:32 ` Angelo Borsotti
2012-10-27 8:44 ` Andreas Schwab
2012-10-27 8:45 ` Ben Walton [this message]
2012-10-27 10:36 ` Angelo Borsotti
2012-10-27 13:14 ` Andreas Schwab
2012-10-27 14:50 ` Angelo Borsotti
2012-10-27 16:12 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2007-11-12 15:35 Jon Smirl
2007-11-12 22:23 ` Alex Riesen
2007-11-12 22:24 ` Johannes Schindelin
2007-11-12 22:26 ` Alex Riesen
2007-11-12 23:09 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP30j15pUwX9sD3FXAfroxFK9paHmb1eAg+M5YAHT4aB22DBEw@mail.gmail.com \
--to=bdwalton@gmail.com \
--cc=angelo.borsotti@gmail.com \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).