From: Christian Couder <christian.couder@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 4/6] fetch: report errors when backfilling tags fails
Date: Tue, 15 Feb 2022 08:52:14 +0100 [thread overview]
Message-ID: <CAP8UFD0MQCpFfWg2FP3S1VpDAxCwp3WGucFPn7K9BZ7UnckNLw@mail.gmail.com> (raw)
In-Reply-To: <54fdee845bea7f67f46817417f8e5a504bd39665.1644565025.git.ps@pks.im>
On Fri, Feb 11, 2022 at 9:03 PM Patrick Steinhardt <ps@pks.im> wrote:
>
> When the backfilling of tags fails we do not report this error to the
> caller, but only report it implicitly at a later point when reporting
> updated references.
Probably stupid question: are we sure that it's a bug and not a feature?
> This leaves callers unable to act upon the
> information of whether the backfilling succeeded or not.
>
> Refactor the function to return an error code and pass it up the
> callstack. This causes us to correctly propagate the error back to the
> user of git-fetch(1).
Even if it would have been the right behavior when backfilling tags
was implemented to return an error when backfilling tags fails, I
think it's interesting to ask ourselves if this change could be seen
as a regression by some users.
next prev parent reply other threads:[~2022-02-15 7:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 7:46 [PATCH 0/6] fetch: improve atomicity of `--atomic` flag Patrick Steinhardt
2022-02-11 7:46 ` [PATCH 1/6] fetch: increase test coverage of fetches Patrick Steinhardt
2022-02-15 6:19 ` Christian Couder
2022-02-17 11:13 ` Patrick Steinhardt
2022-02-11 7:46 ` [PATCH 2/6] fetch: backfill tags before setting upstream Patrick Steinhardt
2022-02-15 6:43 ` Christian Couder
2022-02-11 7:46 ` [PATCH 3/6] fetch: control lifecycle of FETCH_HEAD in a single place Patrick Steinhardt
2022-02-15 7:32 ` Christian Couder
2022-02-17 11:18 ` Patrick Steinhardt
2022-02-11 7:46 ` [PATCH 4/6] fetch: report errors when backfilling tags fails Patrick Steinhardt
2022-02-15 7:52 ` Christian Couder [this message]
2022-02-17 11:27 ` Patrick Steinhardt
2022-02-17 12:47 ` Patrick Steinhardt
2022-02-16 23:35 ` Jonathan Tan
2022-02-17 1:31 ` Elijah Newren
2022-02-11 7:47 ` [PATCH 5/6] fetch: make `--atomic` flag cover backfilling of tags Patrick Steinhardt
2022-02-15 8:11 ` Christian Couder
2022-02-16 23:41 ` Jonathan Tan
2022-02-17 11:37 ` Patrick Steinhardt
2022-02-17 1:34 ` Elijah Newren
2022-02-17 11:58 ` Patrick Steinhardt
2022-02-11 7:47 ` [PATCH 6/6] fetch: make `--atomic` flag cover pruning of refs Patrick Steinhardt
2022-02-15 9:12 ` Christian Couder
2022-02-17 12:03 ` Patrick Steinhardt
2022-02-16 23:39 ` Jonathan Tan
2022-02-17 1:40 ` Elijah Newren
2022-02-17 12:06 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD0MQCpFfWg2FP3S1VpDAxCwp3WGucFPn7K9BZ7UnckNLw@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).