From: Christian Couder <christian.couder@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Josh Steadmon <steadmon@google.com>,
Achu Luma <ach.lumap@gmail.com>
Subject: Re: [PATCH 3/3] t-ctype: do one test per class and char
Date: Mon, 26 Feb 2024 10:28:14 +0100 [thread overview]
Message-ID: <CAP8UFD0Wi3ot-t0Q7ruMauwj4zkMfd89Xr9SmxYa4eQ3=2VKOw@mail.gmail.com> (raw)
In-Reply-To: <20240225112722.89221-4-l.s.r@web.de>
On Sun, Feb 25, 2024 at 12:27 PM René Scharfe <l.s.r@web.de> wrote:
>
> Simplify TEST_CHAR_CLASS by using TEST for each character separately.
> This increases the number of tests to 3598,
Does this mean that when all the tests pass there will be 3598 lines
of output on the terminal instead of 14 before this patch?
If that's the case, I don't like this.
> but avoids the need for
> using internal functions and test_msg() for custom messages. The
> resulting macro has minimal test setup overhead.
Yeah, the code looks definitely cleaner, but a clean output is important too.
Thanks!
next prev parent reply other threads:[~2024-02-26 9:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 11:27 [PATCH 0/3] t-ctype: simplify unit test definitions René Scharfe
2024-02-25 11:27 ` [PATCH 1/3] t-ctype: allow NUL anywhere in the specification string René Scharfe
2024-02-25 18:05 ` Eric Sunshine
2024-02-25 18:28 ` René Scharfe
2024-02-25 18:41 ` Eric Sunshine
2024-02-25 21:00 ` Jeff King
2024-02-25 21:02 ` Eric Sunshine
2024-02-25 11:27 ` [PATCH 2/3] t-ctype: avoid duplicating class names René Scharfe
2024-02-25 11:27 ` [PATCH 3/3] t-ctype: do one test per class and char René Scharfe
2024-02-26 9:28 ` Christian Couder [this message]
2024-02-26 17:26 ` René Scharfe
2024-02-26 17:44 ` Junio C Hamano
2024-02-26 18:58 ` Josh Steadmon
2024-02-27 10:04 ` Christian Couder
2024-03-02 22:00 ` René Scharfe
2024-03-04 10:00 ` Christian Couder
2024-03-06 18:16 ` René Scharfe
2024-03-04 18:35 ` Josh Steadmon
2024-03-04 18:46 ` Junio C Hamano
2024-03-03 10:13 ` [PATCH v2 0/4] t-ctype: simplify unit test definitions René Scharfe
2024-03-03 10:13 ` [PATCH v2 1/4] t-ctype: allow NUL anywhere in the specification string René Scharfe
2024-03-03 10:13 ` [PATCH v2 2/4] t-ctype: simplify EOF check René Scharfe
2024-03-03 10:13 ` [PATCH v2 3/4] t-ctype: align output of i René Scharfe
2024-03-03 10:13 ` [PATCH v2 4/4] t-ctype: avoid duplicating class names René Scharfe
2024-03-04 9:51 ` Phillip Wood
2024-03-06 18:16 ` René Scharfe
2024-03-08 14:05 ` Phillip Wood
2024-03-09 11:28 ` Phillip Wood
2024-03-10 12:48 ` René Scharfe
2024-03-04 9:25 ` [PATCH v2 0/4] t-ctype: simplify unit test definitions Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD0Wi3ot-t0Q7ruMauwj4zkMfd89Xr9SmxYa4eQ3=2VKOw@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=ach.lumap@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=phillip.wood123@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).