git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Tiago Botelho <tiagonbotelho@gmail.com>
Cc: git <git@vger.kernel.org>, Tiago Botelho <tiagonbotelho@hotmail.com>
Subject: Re: [PATCH] Implement --first-parent for git rev-list --bisect
Date: Thu, 10 May 2018 07:39:14 +0200	[thread overview]
Message-ID: <CAP8UFD0WmU7D+NGyNDdavixoQFrc=RRR7sgqq039hbmpyPQYWA@mail.gmail.com> (raw)
In-Reply-To: <20180509215728.57046-1-tiagonbotelho@hotmail.com>

Hi Tiago,

On Wed, May 9, 2018 at 11:57 PM, Tiago Botelho <tiagonbotelho@gmail.com> wrote:
> ---

Please add something in the commit message (above the "---") about why
this new feature is useful. For example you could just say that it
will make it possible to implement bisecting on first parents which is
useful for people who don't test all the commits in the feature branch
they merge.

Outside the commit message, so after the "---", you could say that
this patch is based on pu so that it can be on top of
hn/bisect-first-parent, and that this patch is not finished as it
needs some tests. You could also have signaled that by using [RFC
PATCH] in the subject (see the --rfc option of git format-patch).

Thanks,
Christian.

      reply	other threads:[~2018-05-10  5:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 21:57 [PATCH] Implement --first-parent for git rev-list --bisect Tiago Botelho
2018-05-10  5:39 ` Christian Couder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP8UFD0WmU7D+NGyNDdavixoQFrc=RRR7sgqq039hbmpyPQYWA@mail.gmail.com' \
    --to=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tiagonbotelho@gmail.com \
    --cc=tiagonbotelho@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).