From: Christian Couder <christian.couder@gmail.com>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, chriscool@tuxfamily.org, gitster@pobox.com,
j6t@kdbg.org, jnareb@gmail.com
Subject: Re: [PATCH v13 4/8] bisect: introduce support for --no-checkout option.
Date: Tue, 2 Aug 2011 14:16:05 +0200 [thread overview]
Message-ID: <CAP8UFD0kB+dS4cP=4MXKShhMw3-f_uKjtOmYKahNM0uQQkojsQ@mail.gmail.com> (raw)
In-Reply-To: <1312284545-2426-5-git-send-email-jon.seymour@gmail.com>
On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> If --no-checkout is specified, then the bisection process uses:
Yeah, but in this patch you are changing "git bisect--helper" by
adding the [--bisect-mode=checkout|update-ref] option. So it is
strange that you still talk about a --no-checkout option.
> git update-ref --no-deref HEAD <trial>
>
> at each trial instead of:
>
> git checkout <trial>
[...]
> int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> {
> int next_all = 0;
> + int no_checkout = 0;
> + char *bisect_mode=NULL;
> struct option options[] = {
> OPT_BOOLEAN(0, "next-all", &next_all,
> "perform 'git bisect next'"),
> + OPT_STRING(0, "bisect-mode", &bisect_mode, "mode",
> + "the bisection mode either checkout or update-ref. defaults to checkout."),
Nit: I would say : "bisection mode: 'checkout' (default) or 'update-ref'"
Thanks,
Christian.
next prev parent reply other threads:[~2011-08-02 12:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 11:28 [PATCH v13 0/8] bisect: Add support for --no-checkout option Jon Seymour
2011-08-02 11:28 ` [PATCH v13 1/8] bisect: move argument parsing before state modification Jon Seymour
2011-08-02 11:28 ` [PATCH v13 2/8] bisect: use && to connect statements that are deferred with eval Jon Seymour
2011-08-02 11:29 ` [PATCH v13 3/8] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-08-02 11:29 ` [PATCH v13 4/8] bisect: introduce support for --no-checkout option Jon Seymour
2011-08-02 12:16 ` Christian Couder [this message]
2011-08-02 14:42 ` Jon Seymour
2011-08-02 18:00 ` Junio C Hamano
2011-08-02 21:24 ` Jon Seymour
2011-08-02 22:05 ` Junio C Hamano
2011-08-02 22:19 ` Jon Seymour
2011-08-02 11:29 ` [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain Jon Seymour
2011-08-02 12:04 ` Christian Couder
2011-08-02 14:41 ` Jon Seymour
2011-08-03 5:27 ` Christian Couder
2011-08-03 12:46 ` Jon Seymour
2011-08-03 13:24 ` Jon Seymour
2011-08-03 14:09 ` Christian Couder
2011-08-03 15:13 ` Jon Seymour
2011-08-03 19:41 ` Christian Couder
2011-08-02 11:29 ` [PATCH v13 6/8] bisect: add tests for the --no-checkout option Jon Seymour
2011-08-02 11:29 ` [PATCH v13 7/8] bisect: add documentation for " Jon Seymour
2011-08-02 11:29 ` [PATCH v13 8/8] bisect: change bisect function to update BISECT_HEAD, rather than HEAD Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD0kB+dS4cP=4MXKShhMw3-f_uKjtOmYKahNM0uQQkojsQ@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).