From: Christian Couder <christian.couder@gmail.com>
To: "Miriam R." <mirucam@gmail.com>
Cc: git <git@vger.kernel.org>,
Tanushree Tumane <tanushreetumane@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [Outreachy] [PATCH] bisect--helper: avoid free-after-use
Date: Mon, 9 Dec 2019 12:10:26 +0100 [thread overview]
Message-ID: <CAP8UFD1ExQ=hmLK8Sakceh8h9uytF+rVpC_YX3ze0M2LMU+2cw@mail.gmail.com> (raw)
In-Reply-To: <CAN7CjDCU=BPA3n6aDEPEzV8VK=JtYFn5_3CbqYrc5Zpg79m5jw@mail.gmail.com>
On Mon, Dec 9, 2019 at 11:36 AM Miriam R. <mirucam@gmail.com> wrote:
> > > Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> > > Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> > > Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
> > > Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> > > ---
> >
> > Here (after the line starting with "---") you can add comments about
> > the patch. One useful comment here would be to say that this patch is
> > a new version of
> > https://public-inbox.org/git/20191208172813.16518-1-mirucam@gmail.com/
> > which itself has been sent previously by Tanushree
> > (https://public-inbox.org/git/64117cde718f0d56ebfa4c30f4d8fe2155f5cf65.1551003074.git.gitgitgadget@gmail.com/).
> >
> Ok, I'll resend another one (v2) adding this comments. :)
It's not a big deal, but there was no need to resend another one, as
the comment is there only to help reviewers with extra information
related to where the patch comes from. It will not appear in the
commit that will be made from the patch (using `git am`) and I already
gave the information about where the patch comes from in my reply to
the patch.
prev parent reply other threads:[~2019-12-09 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 8:40 [Outreachy] [PATCH] bisect--helper: avoid free-after-use Miriam Rubio
2019-12-09 9:33 ` Johannes Schindelin
2019-12-09 10:22 ` Christian Couder
2019-12-09 10:36 ` Miriam R.
2019-12-09 11:10 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1ExQ=hmLK8Sakceh8h9uytF+rVpC_YX3ze0M2LMU+2cw@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
--cc=tanushreetumane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).