Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines

[Christian Couder <christian.couder@gmail.com>]

Hi Isoken,

On Fri, Oct 20, 2023 at 6:28 AM Isoken Ibizugbe <isokenjune@gmail.com> wrote:
>
> On Thu, Oct 19, 2023 at 9:41 AM Isoken June Ibizugbe
> <isokenjune@gmail.com> wrote:
> >
> > As per the CodingGuidelines document, it is recommended that a single-line
> > message provided to error messages such as die(), error() and warning(),
> > should start with a lowercase letter and should not end with a period.
> > Also this patch fixes the tests broken by the changes.
> >
> > Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>
> > ---
> >  builtin/branch.c          | 66 +++++++++++++++++++--------------------
> >  t/t2407-worktree-heads.sh |  2 +-
> >  t/t3200-branch.sh         | 16 +++++-----
> >  t/t3202-show-branch.sh    | 10 +++---
> >  4 files changed, 47 insertions(+), 47 deletions(-)
> Hello Junio, I would appreciate your comment on this.

Please don't expect Junio to give direct feedback on all the patches
sent to the mailing list. This patch has already been reviewed by
Rubén. If Junio doesn't review it and if this patch is not mentioned
in the next "What's cooking in git.git" email from Junio, it likely
means that you should send a version 3 addressing Rubén's feedback
about the commit message.

Thanks,
Christian.