From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Couder Subject: Re: GSoC Project | Improvise git bisect Date: Mon, 21 Mar 2016 18:53:19 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Johannes Schindelin , Matthieu Moy , Git List , Stefan Beller , Lars Schneider , Jeff King , Troy Moure , Junio C Hamano , Eric Sunshine , Kevin Daudt , Philip Oakley To: Pranit Bauva X-From: git-owner@vger.kernel.org Mon Mar 21 18:53:27 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai418-0007hq-DO for gcvg-git-2@plane.gmane.org; Mon, 21 Mar 2016 18:53:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757577AbcCURxW (ORCPT ); Mon, 21 Mar 2016 13:53:22 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36380 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757387AbcCURxU (ORCPT ); Mon, 21 Mar 2016 13:53:20 -0400 Received: by mail-wm0-f67.google.com with SMTP id l68so23723521wml.3 for ; Mon, 21 Mar 2016 10:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=+A/VTmrlldltAEeNfc7UtXac1PSz4Kkm+f+UIKnmas0=; b=xOl/PKzXB22+PXmB9oQOR1wg1v+fdfnO6cXkJ2ZH0LA9J/Ol8qT1rp8ASRg6NQi3xX JmFi7I3JWiQRgUEvGx36nFqvgOrKxFOugDCX3VLWUUti3FXQ9yJ2KLZtMA8qfQplbDf+ 03ML2LkMpnMT6X7Z81vw8HFAX3fTachy7ECSYMSdbcmtosS6m3wmlMMFjke9etPVNn1a xqLK3QgR/Xqe+1fyTJA5BP13+vNCpM2wWEN2gqtGnq3kX0I+mn3F13wlQCDdYkdIUSQy pcu0m/FAax9HowZcVpzcDZ9cGA0H9/MtXBKzfkA8EBcd67zB9S9oYLSG/+ICQMOjvjI7 EJCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=+A/VTmrlldltAEeNfc7UtXac1PSz4Kkm+f+UIKnmas0=; b=MmRmdIuwklscq6C+hxqFAkqeXrW9xe4xpeZEugk2w5uaZcpJoN5oZFEz7F1OcCiicg wJM+IGslJkiHcQKjQSHSgOdBag30oGU/FglVJHO37pSl5qeXkiXyinURDYMINzQHtAVc GYTppppqcMIbBCFhSatuEnxDMfzAuViu5faEe+e7zq7Cz5brA0AST/ANqaQjKRn6PsQh GLNSen3jSWL9KgB22MqmfeyMxqRuZToPunwa/Ma6UxlwMr5p7CW6QMg6OFBCPQbn/nkQ Q7mwnKD6rMhPQq7G3+VEQP3137oUmEOjrMepgojDogBUwLEvAMz70q0956SAMgofHwTH m8VA== X-Gm-Message-State: AD7BkJJG7KSPm+R8DBoF+zKg77QGC3VUWq8J3PDr/aW/iNq/0J34/wotbJSXUs3j2OKFw8rjLmPaU2ihesbpkA== X-Received: by 10.28.147.72 with SMTP id v69mr14502896wmd.79.1458582799436; Mon, 21 Mar 2016 10:53:19 -0700 (PDT) Received: by 10.194.151.131 with HTTP; Mon, 21 Mar 2016 10:53:19 -0700 (PDT) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi Pranit, On Mon, Mar 21, 2016 at 8:29 AM, Pranit Bauva wrote: > On Mon, Mar 21, 2016 at 12:48 PM, Johannes Schindelin > wrote: >> Hi Pranit, >> >> On Sun, 20 Mar 2016, Pranit Bauva wrote: >> >>> I could first move individual functions to bisect--helper.c. >> >> My suggestion would be to give it a try already with some functionality >> you deem small enough to move to the bisect--helper within a day or so. It >> is always good to test the waters like that, and to include this early >> work in the proposal, also to assess (and to let the reviewers assess) how >> feasible the project is. > > Sure! I will start with check_term_format(). > > Also, I think implementing a new algorithm for bisect along with this > would be too big for a GSoC project Yeah, I also think so. > and I am no algorithm expert. I > will stick to --first-parent along with incremental rewrite. My opinion is that an incremental rewrite by itself is big enough for a GSoC. And it might be difficult to do something else that is bisect related at the same time. So if you want to do the rewrite, just focus on it. If you ever have some time left we will easily find other interesting bisect related improvements. If you really want to do "--first-parent" then you should probably add "Improve git bisect terms" to it in your proposal. Best, Christian.