Option for git bisect run to automatically clean up

Option for git bisect run to automatically clean up

[Laszlo Papp]

Hi everybody,

I have just run into a problem when I had to issue an explicit cleanup for
tracked files after a configure run in the Qt5 project. I have tried to
suggest to the people to bring up this idea on the mailing list in order to
get this further on. Unfortunately I did not have time to do so, especially
for the follow-up. I have also been told it is not a good way of asking on
IRC which surprised me a bit, but I am now bringing this up, and I try to
also make the follow-up. Hope it is ok.

Unfortunately my time is limited so I cannot contribute with that patch
myself, but I think it would be a cool convenience feature. Help is
appreciated. Thank you in advance!

Laszlo

Re: Option for git bisect run to automatically clean up

[Christian Couder]

Hi,

On Thu, Sep 27, 2012 at 6:55 PM, Laszlo Papp <lpapp@kde.org> wrote:
> Hi everybody,
>
> I have just run into a problem when I had to issue an explicit cleanup for
> tracked files after a configure run in the Qt5 project. I have tried to
> suggest to the people to bring up this idea on the mailing list in order to
> get this further on. Unfortunately I did not have time to do so, especially
> for the follow-up. I have also been told it is not a good way of asking on
> IRC which surprised me a bit, but I am now bringing this up, and I try to
> also make the follow-up. Hope it is ok.

At first I thought that your idea was to have an option to "git bisect
run" so that a "git bisect reset" is run automatically after the
bisection is finished.
But I search the IRC log and found the discussion here:

http://colabti.org/irclogger/irclogger_log/git?date=2012-09-27

and I found that you said:

"there should be an option for git bisect run which executed the
"whatever clean command git has like git clean -fdx"./"

I understand that, but I wonder what we should do if some people need
a "git reset --hard" and if some other people need other options than
-dfx.
We would need both a --reset and a --clean, or perhaps even a
--reset[=(hard|mixed|soft|merge|keep) and a --clean[=<clean-opts>].
And then what if people want to clean only a subdirectory and not everything?
And this does not take into account the fact that many people
will/should clean using "make clean" or "make distclean" or "rake
clean" or something like that, so that a --clean option will not help
them.

Best,
Christian.

Re: Option for git bisect run to automatically clean up

[Junio C Hamano]

Christian Couder <christian.couder@gmail.com> writes:

> I understand that, but I wonder what we should do if some people
> need a "git reset --hard" and if some other people need other
> options than -dfx.
> We would need both a --reset and a --clean, or perhaps even a
> --reset[=(hard|mixed|soft|merge|keep) and a --clean[=<clean-opts>].

> And then what if people want to clean only a subdirectory and not
> everything?  And this does not take into account the fact that
> many people will/should clean using "make clean" or "make
> distclean" or "rake clean" or something like that, so that a
> --clean option will not help them.

In short, the users can do that easily in their "run" script, and
the definition of "clean-up" will be different depending on what the
"run" script does (it may do "make" in which case "make clean" may
be a way, it may do "git apply fixup.patch" in which case "git apply
-R fixup.patch" may be the way, etc.), so adding "--clean" does not
help the users.  Just make the "run" script clean after itself.

If that is the argument, I'd buy that.