From: Christian Couder <christian.couder@gmail.com>
To: Kevin Daudt <me@ikke.info>
Cc: Christian Couder <chriscool@tuxfamily.org>, git <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script
Date: Wed, 18 Oct 2017 23:25:49 +0200 [thread overview]
Message-ID: <CAP8UFD2D7hUVkE=5bpk7sn8DnUgtwZmj-Q4xHCej279LJvMKyg@mail.gmail.com> (raw)
In-Reply-To: <20171018105801.GF19335@alpha.vpn.ikke.info>
On Wed, Oct 18, 2017 at 12:58 PM, Kevin Daudt <me@ikke.info> wrote:
> On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote:
>> diff --git a/t/perf/run b/t/perf/run
>> index beb4acc0e428d..1e7c2a59e45dc 100755
>> --- a/t/perf/run
>> +++ b/t/perf/run
>> @@ -2,9 +2,14 @@
>>
>> case "$1" in
>> --help)
>> - echo "usage: $0 [other_git_tree...] [--] [test_scripts]"
>> + echo "usage: $0 [--config file] [other_git_tree...] [--] [test_scripts]"
>> exit 0
>> ;;
>> + --config)
>> + shift
>> + GIT_PERF_CONFIG_FILE=$(cd "$(dirname "$1")"; pwd)/$(basename "$1")
>
> Is the idea of this construct to do some kind of normalization?
> Otherwise it seems to just result in $1 again.
Yeah, the idea is to get a full path when you are given a relative path.
prev parent reply other threads:[~2017-10-18 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAP8UFD3tG3fOgftFJAB4mKD2N+uAH0aac4RmFmdXZ=ORHmKzQQ@mail.gmail.com>
2017-09-23 19:55 ` [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script Christian Couder
2017-09-23 19:55 ` [PATCH v2 5/9] perf/run: add get_subsections() Christian Couder
2017-09-23 19:55 ` [PATCH v2 2/9] perf/run: add get_var_from_env_or_config() Christian Couder
2017-09-23 19:55 ` [PATCH v2 3/9] perf/run: add GIT_PERF_DIRS_OR_REVS Christian Couder
2017-09-23 19:55 ` [PATCH v2 8/9] perf/run: show name of rev being built Christian Couder
2017-09-23 19:55 ` [PATCH v2 7/9] perf/run: add run_subsection() Christian Couder
2017-09-23 19:55 ` [PATCH v2 6/9] perf/run: update get_var_from_env_or_config() for subsections Christian Couder
2017-09-23 19:55 ` [PATCH v2 4/9] perf/run: add calls to get_var_from_env_or_config() Christian Couder
2017-09-23 19:55 ` [PATCH v2 9/9] perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/" Christian Couder
2017-10-16 5:25 ` [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script Junio C Hamano
2017-11-17 7:58 ` Christian Couder
2017-11-24 10:28 ` Ævar Arnfjörð Bjarmason
2017-10-18 10:58 ` Kevin Daudt
2017-10-18 21:25 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD2D7hUVkE=5bpk7sn8DnUgtwZmj-Q4xHCej279LJvMKyg@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).