From: Christian Couder <christian.couder@gmail.com>
To: Naomi Ibe <naomi.ibeh69@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635
Date: Mon, 9 Oct 2023 10:22:53 +0200 [thread overview]
Message-ID: <CAP8UFD2hCPh2cVZ_xUeJU0OLw9RzJwGiT9TperzRyYwcw4uvPQ@mail.gmail.com> (raw)
In-Reply-To: <CACS=G2zcU+o6av=CQy7WAG7DZmNEERcPqB_W3Cmub4w25V3K4g@mail.gmail.com>
On Mon, Oct 9, 2023 at 9:57 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
>
> Thank you very much for the feedback Christian, I'd definitely keep
> this in mind the next time I'm creating/sending a patch.
Great!
> You also said asides working on my commit message, the patch looks
> good,
Yeah, but first others might find some issues in the patch itself,
also, as I say elsewhere, I think it's worth it for you to send a
version 2 of the patch that fixes the commit message issues I pointed
out.
> but as I'm applying to Outreachy, I need to send in my proof of
> contribution as a link of a task I worked on.
> Would sending a link of the mailing list , with the url of this patch
> I just worked on suffice?Something like this :
> https://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@gmail.com/T/#u
> I ask because since I used patches to send to Git , I have no pull
> request link to submit.
Yeah, links to the emails you sent in a mailing list archive (Public
Inbox or lore.kernel.org/git) are fine.
next prev parent reply other threads:[~2023-10-09 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 1:16 [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Naomi Ibe
2023-10-09 7:27 ` Christian Couder
2023-10-09 7:57 ` Naomi Ibe
2023-10-09 8:22 ` Christian Couder [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-09 1:15 Naomi Ibe
2023-10-09 18:49 ` Junio C Hamano
2023-10-10 15:19 ` Naomi Ibe
2023-10-10 19:22 ` Christian Couder
2023-10-10 22:24 ` Junio C Hamano
2023-10-11 5:50 ` Naomi Ibe
2023-10-11 6:17 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2hCPh2cVZ_xUeJU0OLw9RzJwGiT9TperzRyYwcw4uvPQ@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=naomi.ibeh69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).