From: Christian Couder <christian.couder@gmail.com>
To: Joel Teichroeb <joel@teichroeb.net>
Cc: Git Mailing List <git@vger.kernel.org>,
Thomas Gummerer <t.gummerer@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 3/4] stash: convert drop and clear to builtin
Date: Sat, 24 Mar 2018 19:22:56 +0100 [thread overview]
Message-ID: <CAP8UFD2yudVPNya8sTTd5UUq7Doxp2VqSf+aCecJPHE_c1VoqA@mail.gmail.com> (raw)
In-Reply-To: <20180324173707.17699-4-joel@teichroeb.net>
> + argv_array_pushl(&args, "reflog", "delete", "--updateref", "--rewrite", NULL);
> + argv_array_push(&args, info->revision);
> + ret = cmd_reflog(args.argc, args.argv, prefix);
> + if (!ret) {
> + if (!quiet) {
> + printf(_("Dropped %s (%s)\n"), info->revision, sha1_to_hex(info->w_commit.hash));
> + }
The brackets are not needed.
> + } else {
> + return error(_("%s: Could not drop stash entry"), info->revision);
> + }
next prev parent reply other threads:[~2018-03-24 18:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 17:37 [PATCH 0/4] Convert some stash functionality to a builtin Joel Teichroeb
2018-03-24 17:37 ` [PATCH 1/4] stash: convert apply to builtin Joel Teichroeb
2018-03-24 18:19 ` Christian Couder
2018-03-25 6:40 ` Eric Sunshine
2018-03-25 9:27 ` Christian Couder
2018-03-25 8:09 ` Christian Couder
2018-03-25 16:51 ` Joel Teichroeb
2018-03-25 19:58 ` Christian Couder
[not found] ` <20180325204653.1470-1-avarab@gmail.com>
2018-03-25 20:57 ` [PATCH] Remove contrib/examples/* Ævar Arnfjörð Bjarmason
2018-03-26 6:01 ` Jeff King
2018-03-26 20:58 ` Junio C Hamano
2018-03-25 16:43 ` [PATCH 1/4] stash: convert apply to builtin Thomas Gummerer
2018-03-28 3:30 ` Joel Teichroeb
2018-03-25 17:23 ` Thomas Gummerer
2018-03-24 17:37 ` [PATCH 2/4] stash: convert branch " Joel Teichroeb
2018-03-25 6:44 ` Eric Sunshine
2018-03-25 8:22 ` Christian Couder
2018-03-25 17:02 ` Thomas Gummerer
2018-03-24 17:37 ` [PATCH 3/4] stash: convert drop and clear " Joel Teichroeb
2018-03-24 18:22 ` Christian Couder [this message]
2018-03-25 6:49 ` Eric Sunshine
2018-03-24 17:37 ` [PATCH 4/4] stash: convert pop " Joel Teichroeb
2018-03-25 6:51 ` Eric Sunshine
2018-03-25 17:36 ` Thomas Gummerer
2018-03-25 17:39 ` [PATCH 0/4] Convert some stash functionality to a builtin Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2yudVPNya8sTTd5UUq7Doxp2VqSf+aCecJPHE_c1VoqA@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=joel@teichroeb.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).