From: Christian Couder <christian.couder@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Josh Steadmon <steadmon@google.com>,
Achu Luma <ach.lumap@gmail.com>
Subject: Re: [PATCH v2 0/4] t-ctype: simplify unit test definitions
Date: Mon, 4 Mar 2024 10:25:20 +0100 [thread overview]
Message-ID: <CAP8UFD395xDjgqxg=S7dZrbnsCNsMEqQbKBipMU4m45CfT8f0w@mail.gmail.com> (raw)
In-Reply-To: <20240303101330.20187-1-l.s.r@web.de>
On Sun, Mar 3, 2024 at 11:13 AM René Scharfe <l.s.r@web.de> wrote:
>
> Simplify the ctype unit tests to allow combining specification strings
> in any order and no longer require repeating class names.
>
> Changes since v1:
> * Added checks to guard string length calculation using sizeof.
> * Kept the definition string in the error output.
> * Added patches 2 and 3 with further cosmetic changes.
> * Dropped the last patch with the huge output for now, as it needs
> further thought.
This V2 looks good to me. Acked.
prev parent reply other threads:[~2024-03-04 9:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 11:27 [PATCH 0/3] t-ctype: simplify unit test definitions René Scharfe
2024-02-25 11:27 ` [PATCH 1/3] t-ctype: allow NUL anywhere in the specification string René Scharfe
2024-02-25 18:05 ` Eric Sunshine
2024-02-25 18:28 ` René Scharfe
2024-02-25 18:41 ` Eric Sunshine
2024-02-25 21:00 ` Jeff King
2024-02-25 21:02 ` Eric Sunshine
2024-02-25 11:27 ` [PATCH 2/3] t-ctype: avoid duplicating class names René Scharfe
2024-02-25 11:27 ` [PATCH 3/3] t-ctype: do one test per class and char René Scharfe
2024-02-26 9:28 ` Christian Couder
2024-02-26 17:26 ` René Scharfe
2024-02-26 17:44 ` Junio C Hamano
2024-02-26 18:58 ` Josh Steadmon
2024-02-27 10:04 ` Christian Couder
2024-03-02 22:00 ` René Scharfe
2024-03-04 10:00 ` Christian Couder
2024-03-06 18:16 ` René Scharfe
2024-03-04 18:35 ` Josh Steadmon
2024-03-04 18:46 ` Junio C Hamano
2024-03-03 10:13 ` [PATCH v2 0/4] t-ctype: simplify unit test definitions René Scharfe
2024-03-03 10:13 ` [PATCH v2 1/4] t-ctype: allow NUL anywhere in the specification string René Scharfe
2024-03-03 10:13 ` [PATCH v2 2/4] t-ctype: simplify EOF check René Scharfe
2024-03-03 10:13 ` [PATCH v2 3/4] t-ctype: align output of i René Scharfe
2024-03-03 10:13 ` [PATCH v2 4/4] t-ctype: avoid duplicating class names René Scharfe
2024-03-04 9:51 ` Phillip Wood
2024-03-06 18:16 ` René Scharfe
2024-03-08 14:05 ` Phillip Wood
2024-03-09 11:28 ` Phillip Wood
2024-03-10 12:48 ` René Scharfe
2024-03-04 9:25 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD395xDjgqxg=S7dZrbnsCNsMEqQbKBipMU4m45CfT8f0w@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=ach.lumap@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=phillip.wood123@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).