* [PATCH 0/1] *** EDITED add.c ***
@ 2023-10-09 1:18 Naomi Ibe
2023-10-09 7:38 ` Christian Couder
0 siblings, 1 reply; 5+ messages in thread
From: Naomi Ibe @ 2023-10-09 1:18 UTC (permalink / raw)
To: git; +Cc: Naomi Ibe
*** BLURB HERE ***
Naomi (1):
[OUTREACHY] Fixed add.c file to conform to guidelines when using die()
listed in issue #635
builtin/add.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.36.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 0/1] *** EDITED add.c ***
2023-10-09 1:18 [PATCH 0/1] *** EDITED add.c *** Naomi Ibe
@ 2023-10-09 7:38 ` Christian Couder
2023-10-09 7:45 ` Naomi Ibe
0 siblings, 1 reply; 5+ messages in thread
From: Christian Couder @ 2023-10-09 7:38 UTC (permalink / raw)
To: Naomi Ibe; +Cc: git
On Mon, Oct 9, 2023 at 3:19 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
>
> *** BLURB HERE ***
A patch with number 0/X (where X is any number) is called a "cover
letter" and is supposed to explain the purpose of the patch series it
is part of. Usually a cover letter is not useful for a single patch
long patch series (when X is 1), as the commit message of the patch
should be enough.
Also things like "*** BLURB HERE ***" (including the stars) are
supposed to be replaced by a subject or some comments to explain
things.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] *** EDITED add.c ***
2023-10-09 7:38 ` Christian Couder
@ 2023-10-09 7:45 ` Naomi Ibe
2023-10-09 8:03 ` Christian Couder
0 siblings, 1 reply; 5+ messages in thread
From: Naomi Ibe @ 2023-10-09 7:45 UTC (permalink / raw)
To: Christian Couder; +Cc: git
Okay I understand it better now ,can I do anything about it? Or should
I leave it as is?.
It's my first time using the "git patch" and "git send-email"
commands, so it was a real struggle understanding the proper way to
get things setup.
On Mon, Oct 9, 2023 at 8:39 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Mon, Oct 9, 2023 at 3:19 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
> >
> > *** BLURB HERE ***
>
> A patch with number 0/X (where X is any number) is called a "cover
> letter" and is supposed to explain the purpose of the patch series it
> is part of. Usually a cover letter is not useful for a single patch
> long patch series (when X is 1), as the commit message of the patch
> should be enough.
>
> Also things like "*** BLURB HERE ***" (including the stars) are
> supposed to be replaced by a subject or some comments to explain
> things.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] *** EDITED add.c ***
2023-10-09 7:45 ` Naomi Ibe
@ 2023-10-09 8:03 ` Christian Couder
2023-10-09 8:14 ` Naomi Ibe
0 siblings, 1 reply; 5+ messages in thread
From: Christian Couder @ 2023-10-09 8:03 UTC (permalink / raw)
To: Naomi Ibe; +Cc: git
On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
>
> Okay I understand it better now ,can I do anything about it? Or should
> I leave it as is?.
I think you should send a version 2 of the patch (so without a cover
letter) taking into account the comments I made about it. You might
want to wait a bit before sending version 2 though, so that others
might have time to read your patch and give you more feedback about
it.
> It's my first time using the "git patch
I guess you mean `git format-patch`.
> and "git send-email"
> commands, so it was a real struggle understanding the proper way to
> get things setup.
Yeah, it's not easy to set things up, but once that's done it should
be much easier. To make things even easier, you could perhaps save
somewhere the commands that you have previously used. And to improve
or make changes to those commands, you could take a look at the
documentation for `git format-patch` and `git send-email` which have a
number of interesting options, and take note of those interesting
options.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] *** EDITED add.c ***
2023-10-09 8:03 ` Christian Couder
@ 2023-10-09 8:14 ` Naomi Ibe
0 siblings, 0 replies; 5+ messages in thread
From: Naomi Ibe @ 2023-10-09 8:14 UTC (permalink / raw)
To: Christian Couder; +Cc: git
Okay then, I'd wait for additional feedback and send in a Version 2
later. Thank you
On Mon, Oct 9, 2023 at 9:03 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Mon, Oct 9, 2023 at 9:46 AM Naomi Ibe <naomi.ibeh69@gmail.com> wrote:
> >
> > Okay I understand it better now ,can I do anything about it? Or should
> > I leave it as is?.
>
> I think you should send a version 2 of the patch (so without a cover
> letter) taking into account the comments I made about it. You might
> want to wait a bit before sending version 2 though, so that others
> might have time to read your patch and give you more feedback about
> it.
>
> > It's my first time using the "git patch
>
> I guess you mean `git format-patch`.
>
> > and "git send-email"
> > commands, so it was a real struggle understanding the proper way to
> > get things setup.
>
> Yeah, it's not easy to set things up, but once that's done it should
> be much easier. To make things even easier, you could perhaps save
> somewhere the commands that you have previously used. And to improve
> or make changes to those commands, you could take a look at the
> documentation for `git format-patch` and `git send-email` which have a
> number of interesting options, and take note of those interesting
> options.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-09 8:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 1:18 [PATCH 0/1] *** EDITED add.c *** Naomi Ibe
2023-10-09 7:38 ` Christian Couder
2023-10-09 7:45 ` Naomi Ibe
2023-10-09 8:03 ` Christian Couder
2023-10-09 8:14 ` Naomi Ibe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).