From: Christian Couder <christian.couder@gmail.com>
To: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [GSoC][PATCH] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c
Date: Fri, 7 Jun 2024 10:41:46 +0200 [thread overview]
Message-ID: <CAP8UFD3aTC_s8BgXYDcM_ecjMQmRsMiNMJxgXD2FLYvt26OwWQ@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2eUxrr2Z0etZKbakXEB5VAfXH63jLhfAYJyOxBwvJPEQ@mail.gmail.com>
On Fri, Jun 7, 2024 at 10:36 AM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Fri, Jun 7, 2024 at 10:31 AM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > On Fri, Jun 7, 2024 at 1:35 AM Ghanshyam Thakkar
> > <shyamthakkar001@gmail.com> wrote:
> > > static void check_each(struct oidtree *ot, char *query, ...)
> > > {
> > > struct object_id oid;
> > > struct strvec hexes = STRVEC_INIT;
> > > struct cb_data cb_data;
> > > const char *arg;
> > > int i = 0;
>
> ... and above only:
>
> struct object_id oid;
> const char *arg;
> struct expected_hex_iter hex_iter = { 0 };
Actually I think it should be:
struct expected_hex_iter hex_iter = { .hexes = STRVEC_INIT };
next prev parent reply other threads:[~2024-06-07 8:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:43 [GSoC][PATCH] t/: migrate helper/test-oidtree.c to unit-tests/t-oidtree.c Ghanshyam Thakkar
2024-06-06 21:54 ` Junio C Hamano
2024-06-06 23:35 ` Ghanshyam Thakkar
2024-06-07 8:31 ` Christian Couder
2024-06-07 8:36 ` Christian Couder
2024-06-07 8:41 ` Christian Couder [this message]
2024-06-07 16:37 ` Junio C Hamano
2024-06-08 16:57 ` [GSoC][PATCH v2] " Ghanshyam Thakkar
2024-06-10 16:40 ` Junio C Hamano
2024-06-10 20:52 ` Ghanshyam Thakkar
2024-06-10 21:06 ` Junio C Hamano
2024-06-10 22:01 ` Ghanshyam Thakkar
2024-06-10 23:20 ` Junio C Hamano
2024-06-10 23:36 ` Ghanshyam Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD3aTC_s8BgXYDcM_ecjMQmRsMiNMJxgXD2FLYvt26OwWQ@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=shyamthakkar001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).