From: Francesco Mazzoli <f@mazzo.li>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] push: add config option to --force-with-lease by default.
Date: Fri, 7 Jul 2017 08:19:34 +0200 [thread overview]
Message-ID: <CAPB=P5xNDdexiyT_mVvcVmmuzS5RUqnhyC3VofPcs5-k5H8BBQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqy3s1e5uw.fsf@gitster.mtv.corp.google.com>
On 6 July 2017 at 21:13, Junio C Hamano <gitster@pobox.com> wrote:
> By that logic, a hypothetical update to `--force` that makes 1/3 of
> the attempted forced push randomly would make it safer than the
> current `--force`, wouldn't it?
It would. However, this additional safety is not really meaningful to any
workflow, while the one added by `--force-with-lease` is.
> When third-party tools fetch and update remote-tracking branches
> behind the users' back, the safety based on the stability of
> remote-tracking branches are defeated. And the biggest problem
> is that the way `--force-with-lease` misbehaves---it is not like
> it randomly and mistakenly stops the push that could go through;
> it lets through what shouldn't.
>
> See the other patch I sent just now---with something like that patch
> that lets those like you, who know their remote-tracking branches
> are reliable, use the lazy form, while disabling it by default for
> others (until they examine their situation and perhaps disable the
> problematic auto-fetching) in place, I do not think it is a bad idea
> to advertise --force-with-lease a safer option than --force (because
> those for whom it is not safer will not be able to use it).
Fair enough, I'm OK with enabling it with some config. I'd still like a
way to enable it by default if I want though.
Thanks,
Francesco
next prev parent reply other threads:[~2017-07-07 6:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 21:18 [PATCH] push: add config option to --force-with-lease by default Francesco Mazzoli
2017-07-03 21:47 ` Ævar Arnfjörð Bjarmason
2017-07-03 21:57 ` Francesco Mazzoli
2017-07-03 22:08 ` Francesco Mazzoli
2017-07-03 22:15 ` Ævar Arnfjörð Bjarmason
2017-07-03 22:28 ` Ævar Arnfjörð Bjarmason
2017-07-04 17:51 ` Junio C Hamano
2017-07-05 6:34 ` Francesco Mazzoli
2017-07-05 7:43 ` Junio C Hamano
2017-07-05 8:04 ` Francesco Mazzoli
2017-07-05 15:17 ` Junio C Hamano
2017-07-05 16:43 ` Francesco Mazzoli
2017-07-05 18:51 ` Mike Rappazzo
2017-07-06 19:13 ` Junio C Hamano
2017-07-07 6:19 ` Francesco Mazzoli [this message]
2017-07-05 11:26 ` Ævar Arnfjörð Bjarmason
2017-07-05 15:48 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPB=P5xNDdexiyT_mVvcVmmuzS5RUqnhyC3VofPcs5-k5H8BBQ@mail.gmail.com' \
--to=f@mazzo.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).