From: Dan Johnson <computerdruid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Graham Ballantyne <grahamb@sfu.ca>,
git@vger.kernel.org
Subject: Re: Incorrect v1.7.10.4 tag on github?
Date: Mon, 2 Jul 2012 15:52:31 -0400 [thread overview]
Message-ID: <CAPBPrnspD3uC6_wd7nqMUVgHSt4Frwy8UaYL6fU73kJKX6=XWQ@mail.gmail.com> (raw)
In-Reply-To: <7vvcis9ylx.fsf@alter.siamese.dyndns.org>
On Fri, Jun 15, 2012 at 3:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:
>>
>>> I just downloaded the 1.7.10.4 tag from github. After compiling and
>>> installing, git --version returns "git version 1.7.10.3". I think that
>>> tag might be pointing to the wrong commit?
>>
>> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR
>> in GIT-VERSION-GEN. Operator error from the maintainer?
>
> Thanks for noticing.
>
>> It builds with the right version from the git repository (which runs
>> git-describe and sees we are on the v1.7.10.4 tag), but exporting the
>> tag's contents and building fails. I suspect that the git-1.7.10.4
>> tarball on kernel.org would also have the same problem.
>
> It builds correctly if you download the tarball from the official
> location in the [ANNOUNCE] message. This is because the build
> procedure for the official tarball does a bit more than just running
> "git archive-tar", which is what gitweb download interface does
> (namely, it adds the correct "version" file).
Junio,
I just noticed that the download buttons (for tarballs) on gitscm.com
all point to the github tag list ( https://github.com/git/git/tags )
instead of the location pointed to by your [ANNOUNCE] message (
http://code.google.com/p/git-core/downloads/list )
If you do something special as part of releasing these tarballs, is
this something that should be corrected? I can look at the source and
do a pull request for gitscm.com a little later, if needed.
--
-Dan Johnson
next prev parent reply other threads:[~2012-07-02 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 16:51 Incorrect v1.7.10.4 tag on github? Graham Ballantyne
2012-06-15 18:25 ` Jeff King
2012-06-15 19:14 ` Junio C Hamano
2012-06-15 19:17 ` Jeff King
2012-07-02 19:52 ` Dan Johnson [this message]
2012-07-02 20:08 ` Jeff King
2012-07-02 21:00 ` Junio C Hamano
2012-07-02 21:11 ` Scott Chacon
2012-07-02 21:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPBPrnspD3uC6_wd7nqMUVgHSt4Frwy8UaYL6fU73kJKX6=XWQ@mail.gmail.com' \
--to=computerdruid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=grahamb@sfu.ca \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).