From: Subhaditya Nath <sn03.general@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] t7422: remove extraneous argument to printf
Date: Wed, 9 Apr 2025 21:59:04 +0530 [thread overview]
Message-ID: <CAPHxB8un1w-NBnfLne9d=vv9Sqa69eGoLhjOM0GcmhgkYKt-PA@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cT1dQL+MfUctyw=9O5Wd2yUqA40pXSgsRHKfNf=6vxQ7w@mail.gmail.com>
On Thu, Apr 3, 2025 at 10:35 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> [...] for the sake of consistency and to match the author's original
> intent, it may make more sense to retain the argument to printf and
> instead employ `%d`.
I see.
The problem is, there are multiple ways the printf statement could be
written -
1) printf "[submodule \"sm-$i\"]\npath = recursive-submodule-path-$i\n"
2) printf "[submodule \"sm-$i\"]\npath =
recursive-submodule-path-%d\n" "$i"
3) printf "[submodule \"sm-%d\"]\npath =
recursive-submodule-path-$i\n" "$i"
4) printf "[submodule \"sm-%d\"]\npath =
recursive-submodule-path-%d\n" "$i" "$i"
Which one of these is to be used?
I shall update the patch with the approach that is decided upon.
Respectfully,
S.
P.S. Sorry for the delay in replying. I got caught up in something...
next prev parent reply other threads:[~2025-04-09 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 14:48 [PATCH] t7422: remove extraneous argument to printf Subhaditya Nath
2025-04-03 17:05 ` Eric Sunshine
2025-04-09 16:19 ` Junio C Hamano
2025-04-09 16:29 ` Subhaditya Nath [this message]
2025-04-09 16:32 ` Subhaditya Nath
2025-04-09 17:00 ` Eric Sunshine
2025-04-09 18:06 ` Junio C Hamano
2025-04-09 19:11 ` [PATCH] t7422: fix extra printf argument, eliminate loops Subhaditya Nath
2025-04-09 19:11 ` Subhaditya Nath
2025-04-10 12:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPHxB8un1w-NBnfLne9d=vv9Sqa69eGoLhjOM0GcmhgkYKt-PA@mail.gmail.com' \
--to=sn03.general@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).