From: Tao Klerks <tao@klerks.biz>
To: Junio C Hamano <gitster@pobox.com>
Cc: Tao Klerks via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] t7063: mtime-mangling instead of delays in untracked cache testing
Date: Tue, 1 Mar 2022 10:44:53 +0100 [thread overview]
Message-ID: <CAPMMpojHUds8dxKNQcMe6nLj_W6ANazpTH38jBzWix4oLHshPg@mail.gmail.com> (raw)
In-Reply-To: <xmqqr17my6pq.fsf@gitster.g>
On Mon, Feb 28, 2022 at 11:19 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Tao Klerks via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +chmmtime_worktree_root () {
>
> Not "chmtime_worktree_root"? Is doubled-m intended?
>
Oops, typo, fixing.
> > + # chmtime doesnt handle relative paths on windows, so need
> > + # to "hardcode" a reference to the worktree folder name.
> > + cd .. &&
> > + test-tool chmtime $1 worktree &&
> > + cd worktree
>
> An unsuspecting caller will be left in a directory it didn't expect
> to when "test-tool chmtime" fails, which is not nice.
>
> (
> cd .. &&
> test-tool chmtime "$1" worktree
> )
>
> at least until the tool learns to do
>
> test-tool chmtime "$1" ../worktree
>
> or
>
> test-tool -C.. chmtime "$1" worktree
>
> Oh, isn't the last one already available?
Ah, lovely, thank you!
next prev parent reply other threads:[~2022-03-01 9:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 9:40 [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks via GitGitGadget
2022-02-28 9:40 ` [PATCH 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-02-28 15:27 ` Jeff Hostetler
2022-02-28 22:01 ` Junio C Hamano
2022-03-01 8:16 ` Tao Klerks
2022-02-28 22:00 ` Junio C Hamano
2022-03-01 8:21 ` Tao Klerks
2022-02-28 9:40 ` [PATCH 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-02-28 22:19 ` Junio C Hamano
2022-03-01 9:44 ` Tao Klerks [this message]
2022-02-28 11:03 ` [PATCH 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Ævar Arnfjörð Bjarmason
2022-02-28 15:29 ` Jeff Hostetler
2022-03-01 9:45 ` [PATCH v2 " Tao Klerks via GitGitGadget
2022-03-01 9:45 ` [PATCH v2 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-03-01 16:34 ` Jeff Hostetler
2022-03-01 21:14 ` Tao Klerks
2022-03-01 9:45 ` [PATCH v2 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-03-01 18:03 ` Junio C Hamano
2022-03-01 22:13 ` Tao Klerks
2022-03-01 9:49 ` [PATCH v2 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks
2022-03-01 17:49 ` Junio C Hamano
2022-03-02 6:05 ` [PATCH v3 " Tao Klerks via GitGitGadget
2022-03-02 6:05 ` [PATCH v3 1/2] t/helper/test-chmtime: update mingw to support chmtime on directories Tao Klerks via GitGitGadget
2022-03-09 21:46 ` Johannes Schindelin
2022-03-02 6:05 ` [PATCH v3 2/2] t7063: mtime-mangling instead of delays in untracked cache testing Tao Klerks via GitGitGadget
2022-03-09 21:53 ` Johannes Schindelin
2022-03-05 4:24 ` [PATCH v3 0/2] Reduce explicit sleep calls in t7063 untracked cache tests Tao Klerks
2022-03-06 21:57 ` Junio C Hamano
2022-03-07 5:37 ` Tao Klerks
2022-03-07 18:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPMMpojHUds8dxKNQcMe6nLj_W6ANazpTH38jBzWix4oLHshPg@mail.gmail.com \
--to=tao@klerks.biz \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).