From: Usman Akinyemi <usmanakinyemi202@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Usman Akinyemi via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Phillip Wood Phillip Wood <phillip.wood@dunelm.org.uk>,
shejialuo <shejialuo@gmail.com>
Subject: Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes
Date: Mon, 7 Oct 2024 09:01:49 +0000 [thread overview]
Message-ID: <CAPSxiM9=CzKzjjQCmqeyt5mNf4jFMTwNzN7pzPhAgbLsM8Um+g@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cTGESaCMfCzP7Zt3Y6JmG_uroCn1cd6_12W1QKLU7hk8A@mail.gmail.com>
On Mon, Oct 7, 2024 at 8:11 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Mon, Oct 7, 2024 at 4:08 AM Patrick Steinhardt <ps@pks.im> wrote:
> > On Mon, Oct 07, 2024 at 07:25:44AM +0000, Usman Akinyemi wrote:
> > > test $base = $(git rev-parse HEAD^) &&
> > > git show >output &&
> > > grep NEVER output >actual &&
> > > test_must_be_empty actual &&
> >
> > That makes sense. The expectation here is that `output` shouldn't
> > contain the string "NEVER" at all. And as grep(1) would fail when it
> > doesn't find a match the whole test would fail like this. So the below
> > would likely be the best solution.
>
> Thanks. I was just about to respond with the same answer. As a bit of
> extra explanation, the &&-chaining means that every command in the
> chain must return "success" (status 0), but the return code of `grep`
> depends upon whether or not it matched any lines. In this case, it
> returned non-zero which caused the test to fail.
Thanks Eric and Partrick. Thanks for the explanation. I will update
the patch then.
next prev parent reply other threads:[~2024-10-07 9:02 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 5:33 [PATCH 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-06 5:33 ` [PATCH 1/2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 5:55 ` Eric Sunshine
2024-10-06 6:31 ` Usman Akinyemi
2024-10-06 5:33 ` [PATCH 2/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 5:48 ` Eric Sunshine
2024-10-06 6:30 ` Usman Akinyemi
2024-10-06 7:28 ` Eric Sunshine
2024-10-06 8:26 ` Usman Akinyemi
2024-10-06 8:31 ` [PATCH v2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 9:19 ` Eric Sunshine
2024-10-06 9:32 ` Usman Akinyemi
2024-10-06 10:21 ` Eric Sunshine
2024-10-06 11:12 ` shejialuo
2024-10-06 12:06 ` Eric Sunshine
2024-10-06 12:28 ` Usman Akinyemi
2024-10-06 13:03 ` shejialuo
2024-10-06 13:27 ` Usman Akinyemi
2024-10-06 13:36 ` shejialuo
2024-10-06 12:29 ` shejialuo
2024-10-06 12:46 ` Usman Akinyemi
2024-10-07 4:19 ` Eric Sunshine
2024-10-06 16:06 ` [PATCH v3 0/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 16:06 ` [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` Usman Akinyemi via GitGitGadget
2024-10-07 6:04 ` Patrick Steinhardt
2024-10-07 8:52 ` phillip.wood123
2024-10-07 9:05 ` Usman Akinyemi
2024-10-06 16:06 ` [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-06 16:31 ` Kristoffer Haugsbakk
2024-10-07 4:38 ` Eric Sunshine
2024-10-07 6:05 ` Patrick Steinhardt
2024-10-07 7:32 ` Usman Akinyemi
2024-10-07 9:00 ` phillip.wood123
2024-10-06 16:18 ` [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi
2024-10-07 4:24 ` Eric Sunshine
2024-10-07 7:25 ` Usman Akinyemi
2024-10-07 8:08 ` Patrick Steinhardt
2024-10-07 8:11 ` Eric Sunshine
2024-10-07 9:01 ` Usman Akinyemi [this message]
2024-10-06 16:21 ` Kristoffer Haugsbakk
2024-10-06 16:26 ` Usman Akinyemi
2024-10-07 5:55 ` Patrick Steinhardt
2024-10-07 10:22 ` [PATCH v4 " Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:28 ` Patrick Steinhardt
2024-10-07 10:51 ` [PATCH v5 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:54 ` Patrick Steinhardt
2024-10-07 11:10 ` Usman Akinyemi
2024-10-07 11:11 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 15:07 ` Phillip Wood
2024-10-07 15:32 ` Usman Akinyemi
2024-10-07 11:12 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Patrick Steinhardt
2024-10-07 11:16 ` Usman Akinyemi
2024-10-07 11:32 ` Patrick Steinhardt
2024-10-07 11:44 ` Usman Akinyemi
2024-10-07 15:32 ` [PATCH v7 " Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 2/2] t3404: replace test with test_line_count() Usman Akinyemi via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPSxiM9=CzKzjjQCmqeyt5mNf4jFMTwNzN7pzPhAgbLsM8Um+g@mail.gmail.com' \
--to=usmanakinyemi202@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).