git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlo Arenas <carenas@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Rostislav Krasny" <rosti.bsd@gmail.com>
Subject: Re: [PATCH] gitk: avoid hardcoded 40 character length for oid
Date: Mon, 11 Oct 2021 13:37:25 -0700	[thread overview]
Message-ID: <CAPUEspha9Ymxaqp17JA5DaftvxeU_XmTZs089D1zb9WidYn+Pg@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cQi_baTaV+Z=UJcrwS+C1dYnQ6bKEA-Bcim2VUOu8VGJA@mail.gmail.com>

On Mon, Oct 11, 2021 at 1:04 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Mon, Oct 11, 2021 at 3:56 PM Carlo Marcelo Arenas Belón
> > diff --git a/gitk b/gitk
> > @@ -12338,6 +12347,18 @@ catch {
> > +if {![catch {exec git config --get extensions.objectformat} oid_type]
> > +    && $oid_type eq "sha256" } {
> > +    set oid_size 64
> > +} else {
> > +    set oid_type "sha1"
> > +    set oid_size 40
> > +}
>
> Should this be using:
>
>     git rev-parse --show-object-format
>
> rather than `git-config`?

definitely a better fit, will be included in the next version.

Carlo

      reply	other threads:[~2021-10-11 20:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 11:47 [RFC PATCH] gitk: avoid hardcoded 40 characters for oid Carlo Marcelo Arenas Belón
2021-10-11 19:55 ` [PATCH] gitk: avoid hardcoded 40 character length " Carlo Marcelo Arenas Belón
2021-10-11 20:03   ` Eric Sunshine
2021-10-11 20:37     ` Carlo Arenas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUEspha9Ymxaqp17JA5DaftvxeU_XmTZs089D1zb9WidYn+Pg@mail.gmail.com \
    --to=carenas@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rosti.bsd@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).