From: Carlo Arenas <carenas@gmail.com>
To: peff@peff.net
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] approxidate: handle pending number for "specials"
Date: Tue, 6 Nov 2018 16:48:28 -0800 [thread overview]
Message-ID: <CAPUEspi12TtKxKGr=tutfLPNPWhaZmGCh7q4D1LRJ9LFTWwKNA@mail.gmail.com> (raw)
In-Reply-To: <20181102052309.GB19234@sigill.intra.peff.net>
On Thu, Nov 1, 2018 at 10:24 PM Jeff King <peff@peff.net> wrote:
>
> static void date_yesterday(struct tm *tm, struct tm *now, int *num)
> {
> + *num = 0;
the only caller (date_time) for this sends num = NULL, so this
triggers a segfault.
the only reference I could find to that apparently unused parameter comes from:
93cfa7c7a8 ("approxidate_careful() reports errorneous date string", 2010-01-26)
and seems to indicate it is optional and therefore a check for NULL
might make sense for all other cases
Carlo
next prev parent reply other threads:[~2018-11-07 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 5:22 [PATCH 0/3] mixed bag of -Wunused-parameter bugfixes Jeff King
2018-11-02 5:22 ` [PATCH 1/3] rev-list: handle flags for --indexed-objects Jeff King
2018-11-02 5:23 ` [PATCH 2/3] approxidate: handle pending number for "specials" Jeff King
2018-11-07 0:48 ` Carlo Arenas [this message]
2018-11-07 1:12 ` Jeff King
2018-11-07 2:08 ` Junio C Hamano
2018-11-02 5:23 ` [PATCH 3/3] pathspec: handle non-terminated strings with :(attr) Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspi12TtKxKGr=tutfLPNPWhaZmGCh7q4D1LRJ9LFTWwKNA@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).