From: Carlo Arenas <carenas@gmail.com>
To: Eli Schwartz <eschwartz@gentoo.org>
Cc: git@vger.kernel.org, gitster@pobox.com, sandals@crustytoothpaste.net
Subject: Re: [PATCH v3] meson: disable PCRE2 dependency by default in macOS
Date: Tue, 15 Jul 2025 05:01:10 -0700 [thread overview]
Message-ID: <CAPUEspjCbi0U6HYxEvpqMW9FPLn98VMePDTNfadQbt_9GHsZsw@mail.gmail.com> (raw)
In-Reply-To: <2414b962-e843-4ac0-814f-bb4bc7aacda7@gentoo.org>
On Mon, Jul 14, 2025 at 6:55 PM Eli Schwartz <eschwartz@gentoo.org> wrote:
>
> Please double-check my work, that this compiler.has_header() is
> sufficient on your reproducer system to detect and disable the
> non-working feature.
it is indeed all that was needed, abd makes me wonder
if a future version of dependency() shouldn't have a "has_header"
parameter like the one used in find_libray() to allow for this
validation to happen internally and fallback as needed.
Posted a v4 with your code and modifications to still allow a
fallback to the wrap.
Carlo
next prev parent reply other threads:[~2025-07-15 12:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 17:26 [PATCH] meson: disable PCRE2 dependency by default Carlo Marcelo Arenas Belón
2025-07-12 17:51 ` brian m. carlson
2025-07-14 14:00 ` Carlo Arenas
2025-07-14 15:20 ` Junio C Hamano
2025-07-14 16:46 ` Carlo Marcelo Arenas Belón
2025-07-14 16:58 ` Junio C Hamano
2025-07-13 12:23 ` [PATCH v2] meson: disable PCRE2 dependency by default in macOS Carlo Marcelo Arenas Belón
2025-07-13 15:42 ` Junio C Hamano
2025-07-13 17:48 ` [PATCH v3] " Carlo Marcelo Arenas Belón
2025-07-15 1:55 ` Eli Schwartz
2025-07-15 8:46 ` Patrick Steinhardt
2025-07-15 8:56 ` Carlo Arenas
2025-07-15 10:32 ` Patrick Steinhardt
2025-07-15 12:08 ` Carlo Arenas
2025-07-15 14:14 ` Eli Schwartz
2025-07-15 12:01 ` Carlo Arenas [this message]
2025-07-15 14:22 ` Eli Schwartz
2025-07-15 11:44 ` [PATCH v4] meson: woraround broken system PCRE2 dependency " Carlo Marcelo Arenas Belón
2025-07-15 16:48 ` Junio C Hamano
2025-07-15 16:50 ` Eric Sunshine
2025-07-16 19:30 ` [PATCH v5] meson: work around " Carlo Marcelo Arenas Belón
2025-07-16 21:13 ` Junio C Hamano
2025-07-16 21:17 ` Junio C Hamano
2025-07-16 22:10 ` Eli Schwartz
2025-07-16 22:17 ` Carlo Arenas
2025-07-18 17:02 ` [PATCH v6] " Carlo Marcelo Arenas Belón
2025-07-23 22:17 ` Junio C Hamano
2025-07-24 5:28 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPUEspjCbi0U6HYxEvpqMW9FPLn98VMePDTNfadQbt_9GHsZsw@mail.gmail.com \
--to=carenas@gmail.com \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).