From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH 2/2] t/Makefile: always test all lint targets when running tests
Date: Tue, 8 Jul 2014 22:42:57 -0700 [thread overview]
Message-ID: <CAPc5daUXZNB=2X8zsrhs9=Z-nV1o1v7KWGydAj6UmBk23UBEEw@mail.gmail.com> (raw)
In-Reply-To: <53BC4569.3020907@web.de>
On Tue, Jul 8, 2014 at 12:24 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>
> Am 07.07.2014 20:13, schrieb Junio C Hamano:
> >
> > So I am not very enthusiastic to see this change myself.
>
> Ok, I understand we do not want to lightly risk false positives. I
> just noticed that I accidentally forgot to sign off this series, so
> I'd resend just the first patch with a proper SOB, ok?
Nah, let's do both and how it plays out. My not being very enthusiastic
myself does not necessarily mean that it is bad for the project. Maybe
most people like it and if I cannot bear with it I can always turn it off
myself for my environment.
I just have a strange feeling that we may be seeing some twisted shell
script updates and when the author gets asked why it was written in
such a strange way, the answer might turn out to be "just to work around
the false positive from the test-lint", which I would not want to see.
next prev parent reply other threads:[~2014-07-09 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 22:19 [PATCH 0/2] always run all lint targets when running the test suite Jens Lehmann
2014-07-03 22:20 ` [PATCH 1/2] t/Makefile: check helper scripts for non-portable shell commands too Jens Lehmann
2014-07-03 22:21 ` [PATCH 2/2] t/Makefile: always test all lint targets when running tests Jens Lehmann
2014-07-07 18:13 ` Junio C Hamano
2014-07-08 19:24 ` Jens Lehmann
2014-07-09 5:42 ` Junio C Hamano [this message]
2014-07-09 19:33 ` [PATCH v2 0/2] always run all lint targets when running the test suite Jens Lehmann
2014-07-09 19:34 ` [PATCH v2 1/2] t/Makefile: check helper scripts for non-portable shell commands too Jens Lehmann
2014-07-09 19:34 ` [PATCH v2 2/2] t/Makefile: always test all lint targets when running tests Jens Lehmann
2014-07-09 5:30 ` [PATCH " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPc5daUXZNB=2X8zsrhs9=Z-nV1o1v7KWGydAj6UmBk23UBEEw@mail.gmail.com' \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).