From: Junio C Hamano <gitster@pobox.com>
To: Edward Thomson <ethomson@edwardthomson.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] format_commit_message: honor `color=auto` for `%C(auto)`
Date: Tue, 24 May 2016 17:55:02 -0700 [thread overview]
Message-ID: <CAPc5daV4Z0gvaOL1H-v-G7RepGyiuir_AnzNx32aM3j2pm0RGw@mail.gmail.com> (raw)
In-Reply-To: <20160524194814.GA12479@zoidberg>
On Tue, May 24, 2016 at 12:48 PM, Edward Thomson
<ethomson@edwardthomson.com> wrote:
> Check that we are configured to display colors in the given context when
> the user specifies a format string of `%C(auto)`, instead of always
> displaying the default color for the given context. This makes
> `%C(auto)` obey the `color=auto` setting and brings its behavior in line
> with the behavior of `%C(auto,<colorname>)`.
>
> This allows the user the ability to specify that color should be
> displayed for a string only when the output is a tty, and to use the
> default color for the given context without having to hardcode a
> color value.
> ---
> pretty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks obviously the right thing to do from a cursory read.
Missing sign-off?
Thanks.
next prev parent reply other threads:[~2016-05-25 0:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 19:48 [PATCH] format_commit_message: honor `color=auto` for `%C(auto)` Edward Thomson
2016-05-25 0:55 ` Junio C Hamano [this message]
2016-05-25 1:26 ` Edward Thomson
-- strict thread matches above, loose matches on Subject: below --
2016-05-25 1:56 Edward Thomson
2016-05-25 22:39 ` Jeff King
2016-05-27 3:47 ` Edward Thomson
2016-05-31 12:23 ` Duy Nguyen
2016-05-31 22:18 ` Jeff King
2016-05-27 3:46 Edward Thomson
2016-05-27 3:55 ` Jeff King
2016-05-27 6:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPc5daV4Z0gvaOL1H-v-G7RepGyiuir_AnzNx32aM3j2pm0RGw@mail.gmail.com \
--to=gitster@pobox.com \
--cc=ethomson@edwardthomson.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).