git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] t5510: become resilient to GETTEXT_POISON
Date: Mon, 25 Jul 2016 08:16:34 -0700	[thread overview]
Message-ID: <CAPc5daVV8EkMXWeTiZN9bEXXAejmbDbT9L7SNCc4jNtXYVomLQ@mail.gmail.com> (raw)
In-Reply-To: <1469439068-2724-1-git-send-email-vascomalmeida@sapo.pt>

On Mon, Jul 25, 2016 at 2:31 AM, Vasco Almeida <vascomalmeida@sapo.pt> wrote:
> Replace gettext poison text with appropriate values to be able to cut
> the right output of git fetch command for comparison.

Hmm, as these tests are _all_ about human-readable output, it probably is
sufficient to skip them using prerequiste, I would think. We do not want each
individual test to have too intimate knowledge on how POISON strings look
like.

  reply	other threads:[~2016-07-25 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25  9:31 [PATCH] t5510: become resilient to GETTEXT_POISON Vasco Almeida
2016-07-25 15:16 ` Junio C Hamano [this message]
2016-07-25 16:07   ` Duy Nguyen
2016-07-26 12:58 ` [PATCH] t5510: skip tests under GETTEXT_POISON build Vasco Almeida
2016-07-26 16:53   ` Junio C Hamano
2016-07-26 20:11     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPc5daVV8EkMXWeTiZN9bEXXAejmbDbT9L7SNCc4jNtXYVomLQ@mail.gmail.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=vascomalmeida@sapo.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).