From: Junio C Hamano <gitster@pobox.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] makefile: add ability to run specific test files
Date: Wed, 9 Jul 2014 21:14:32 -0700 [thread overview]
Message-ID: <CAPc5daWNB0m23tPdYxWmQEpu8PshFWwwZ3n_bSxF6evwM7-61g@mail.gmail.com> (raw)
In-Reply-To: <1404949763.23510.42.camel@jekeller-desk1.amr.corp.intel.com>
On Wed, Jul 9, 2014 at 4:49 PM, Keller, Jacob E
<jacob.e.keller@intel.com> wrote:
> On Wed, 2014-07-09 at 15:59 -0700, Junio C Hamano wrote:
>>
>> What kind of things are missing, exactly? Perhaps that is something
>> you need to fix, instead of mucking with the top-level Makefile.
>
> It uses the git from my environment instead of the git I have built,
> which is bad since I don't really want to run make install.
Are you sure about that? Try adding something like
die("I am broken");
at the very beginning of main() in git.c, rebuild your git (i.e.
"make", not "make install")
and then
$ cd t
$ sh ./t1234-test.sh -v
for any of the test scripts. You should see any test piece that runs "git" sees
"git" dying with that message.
Otherwise, there is something wrong with git you are building. Unless you have
a patch or two to t/test-lib.sh or something that breaks the test framework, you
should be able to test what you just have built without getting affected by what
is installed in your $PATH. After all, that is how we bootstrap git
from a tarball
without any installed version, and friends do not force friends install without
testing first ;-)
next prev parent reply other threads:[~2014-07-10 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 22:36 [PATCH] makefile: add ability to run specific test files Jacob Keller
2014-07-09 22:59 ` Junio C Hamano
2014-07-09 23:49 ` Keller, Jacob E
2014-07-10 4:14 ` Junio C Hamano [this message]
2014-07-10 20:39 ` Keller, Jacob E
2014-07-10 20:44 ` Jeff King
2014-07-10 22:31 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPc5daWNB0m23tPdYxWmQEpu8PshFWwwZ3n_bSxF6evwM7-61g@mail.gmail.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).