From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 0/5] disallow test_when_finished in subshells
Date: Sat, 5 Sep 2015 13:17:35 -0700 [thread overview]
Message-ID: <CAPc5daX5w5yoRyp=Squdhi8nj87bb4zfqea-=wLyze6GhLPV+w@mail.gmail.com> (raw)
In-Reply-To: <20150905175756.GE27660@serenity.lan>
>> Isn't it just the matter of resetting the variable regardless of $BASH
>> (and ignoring
>> a possible refusal to do so under bash) at the beginning of the test, or do you
>> really have to rely on the value of $BASH and do things differently?
>
> Bash doesn't refuse to set it, it lets you update the value; I did think
> that it wouldn't update it if the user had overridden the value, but it
> looks like that was only because I had unset it first. It seems that
> the variable is magic (autoincrementing in subshells and can only be set
> to integer values) but if you unset it then it becomes a normal
> variable.
Yes, resetting to =0 at the very beginning is what I have in mind.
prev parent reply other threads:[~2015-09-05 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 17:58 [RFC] test_when_finished in subshells John Keeping
2015-09-04 18:43 ` Junio C Hamano
2015-09-05 8:54 ` Jeff King
2015-09-05 13:12 ` [PATCH 0/5] disallow " John Keeping
2015-09-05 13:12 ` [PATCH 1/5] t7610: don't use test_config in a subshell John Keeping
2015-09-05 13:12 ` [PATCH 2/5] t5801: don't use test_when_finished " John Keeping
2015-09-05 13:12 ` [PATCH 3/5] test-lib-functions: support "test_config -C <dir> ..." John Keeping
2015-09-05 13:12 ` [PATCH 4/5] t7800: don't use test_config in a subshell John Keeping
2015-09-05 13:12 ` [PATCH 5/5] test-lib-functions: detect test_when_finished in subshell John Keeping
2015-09-06 9:51 ` Eric Sunshine
2015-09-06 11:46 ` John Keeping
2015-09-06 16:22 ` Eric Sunshine
2015-09-05 17:36 ` [PATCH 0/5] disallow test_when_finished in subshells Junio C Hamano
2015-09-05 17:57 ` John Keeping
2015-09-05 20:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPc5daX5w5yoRyp=Squdhi8nj87bb4zfqea-=wLyze6GhLPV+w@mail.gmail.com' \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).