git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Rodrigo Carvalho <rodrigorsdc@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] t4018: add two userdiff tests for R language
Date: Sun, 25 May 2025 18:42:43 -0400	[thread overview]
Message-ID: <CAPig+cQ07SMbfD8Er1Ukdpih_8AL_exbz7U6WzZ3b2js2ge1cg@mail.gmail.com> (raw)
In-Reply-To: <20250525210236.116342-2-rodrigorsdc@gmail.com>

On Sun, May 25, 2025 at 5:03 PM Rodrigo Carvalho <rodrigorsdc@gmail.com> wrote:
> This patch adds two userdiff tests for R programming language
> files. These files define a simple function, with and without
> indentation.
>
> Signed-off-by: Rodrigo Carvalho <rodrigorsdc@gmail.com>
> ---
> diff --git a/t/t4018/r-indent b/t/t4018/r-indent
> @@ -0,0 +1,6 @@
> +RIGHT <- function(a, b) {
> +    c = mean(a, b)
> +    d = c + 2
> +    ChangeMe()
> +    return (d)
> +}

Although nontraditional, do we care that some people define functions
using `=` rather than `<-`?

    foo = function(x) {...}

  reply	other threads:[~2025-05-25 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-25 21:02 [PATCH 1/2] userdiff: add support for R programming language Rodrigo Carvalho
2025-05-25 21:02 ` [PATCH 2/2] t4018: add two userdiff tests for R language Rodrigo Carvalho
2025-05-25 22:42   ` Eric Sunshine [this message]
2025-05-26  5:57 ` [PATCH 1/2] userdiff: add support for R programming language Johannes Sixt
2025-05-27 15:04   ` Junio C Hamano
2025-05-29 21:36     ` Rodrigo Carvalho
2025-05-29 22:16 ` [PATCH v2] " Rodrigo Carvalho
2025-06-03 18:20   ` Junio C Hamano
2025-06-03 21:15     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cQ07SMbfD8Er1Ukdpih_8AL_exbz7U6WzZ3b2js2ge1cg@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=rodrigorsdc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).