From: Eric Sunshine <sunshine@sunshineco.com>
To: Alban Gruin <alban.gruin@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] name-rev: improve name_rev() memory usage
Date: Fri, 1 Mar 2019 13:00:01 -0500 [thread overview]
Message-ID: <CAPig+cQ6-O8hV+7mYFszyFyk0u4aJMe021RqN+tiFn3OS7H0Hw@mail.gmail.com> (raw)
In-Reply-To: <20190301175024.17337-2-alban.gruin@gmail.com>
On Fri, Mar 1, 2019 at 12:50 PM Alban Gruin <alban.gruin@gmail.com> wrote:
> There a condition that will always be false here when name_rev() calls
> itself for the first parent, but it will become useful when name_rev()
> will stop to name commits that are not mentionned in the stdin buffer.
s/mentionned/mentioned/
> If the current commit should not be named, its parents may have to be,
> but they may not. In this case, name_rev() will tell to its caller that
s/tell/report/
> the current commit and its first parent has not used the name, and that
> it can be released. However, if the current commit has been named but
> not its parent, or the reverse, the name will not be released.
>
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
next prev parent reply other threads:[~2019-03-01 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 17:50 [RFC PATCH 0/4] name-rev: improve memory usage Alban Gruin
2019-03-01 17:50 ` [RFC PATCH 1/4] name-rev: improve name_rev() " Alban Gruin
2019-03-01 18:00 ` Eric Sunshine [this message]
2019-03-01 18:44 ` Jeff King
2019-03-02 21:28 ` Johannes Schindelin
2019-03-01 17:50 ` [RFC PATCH 2/4] commit-list: add a function to check if a commit is in a list Alban Gruin
2019-03-01 17:50 ` [RFC PATCH 3/4] name-rev: check if a commit should be named before naming it Alban Gruin
2019-03-01 18:05 ` Eric Sunshine
2019-03-01 18:22 ` Alban Gruin
2019-03-01 18:37 ` Jeff King
2019-03-01 17:50 ` [RFC PATCH 4/4] name-rev: avoid naming from a ref if it’s not a descendant of any commit Alban Gruin
2019-03-01 18:07 ` Eric Sunshine
2019-03-03 19:33 ` Christian Couder
2019-03-03 19:46 ` Christian Couder
2019-03-03 20:27 ` Alban Gruin
2019-03-01 18:42 ` [RFC PATCH 0/4] name-rev: improve memory usage Jeff King
2019-03-01 19:14 ` Alban Gruin
2019-03-01 19:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQ6-O8hV+7mYFszyFyk0u4aJMe021RqN+tiFn3OS7H0Hw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).