From: Eric Sunshine <sunshine@sunshineco.com>
To: Stefan Beller <sbeller@google.com>
Cc: ronnie sahlberg <ronniesahlberg@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCHv8 4/9] receive-pack.c: simplify execute_commands
Date: Tue, 30 Dec 2014 04:10:08 -0500 [thread overview]
Message-ID: <CAPig+cQEfGj8dH+FFOR4UYbNgovhFy_pP8szSpS+0MyNdOvJrw@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kYvv_r8TahfoE5g_5nBQhjsAC3tHvxUUBE4PtKLy8sGhQ@mail.gmail.com>
On Tue, Dec 30, 2014 at 3:42 AM, Stefan Beller <sbeller@google.com> wrote:
> On Mon, Dec 29, 2014 at 11:46 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller <sbeller@google.com> wrote:
>>> No functional changes intended.
>>> +static void check_shallow_bugs(struct command *commands,
>>> + struct shallow_info *si)
>>> +{
>>> + struct command *cmd;
>>> + int checked_connectivity = 1;
>>> + for (cmd = commands; cmd; cmd = cmd->next) {
>>> + if (!should_process_cmd(cmd))
>>> + continue;
>>> +
>>> + if (shallow_update && si->shallow_ref[cmd->index]) {
>>
>> Another issue: In the original code, 'si->shallow_ref[cmd->index]' is
>> only checked if cmd->error_string is NULL, but here you check it
>> unconditionally, despite the commit message claiming no functional
>> changes. Did you verify that such a behavioral change is benign? (This
>> is a genuine question.)
>
> The error != NULL check is done in if (!should_process_cmd(cmd))
Right. Thanks for setting me straight on that.
next prev parent reply other threads:[~2014-12-30 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 2:36 [PATCHv8 0/9] atomic pushes Stefan Beller
2014-12-30 2:36 ` [PATCHv8 1/9] receive-pack.c: add documentation for atomic push support Stefan Beller
2014-12-30 7:08 ` Eric Sunshine
2014-12-30 8:33 ` Stefan Beller
2014-12-30 9:09 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 2/9] send-pack: rename ref_update_to_be_sent to check_to_send_update Stefan Beller
2014-12-30 2:36 ` [PATCHv8 3/9] send-pack.c: add --atomic command line argument Stefan Beller
2014-12-30 2:36 ` [PATCHv8 4/9] receive-pack.c: simplify execute_commands Stefan Beller
2014-12-30 6:11 ` Eric Sunshine
2014-12-30 8:41 ` Stefan Beller
2014-12-30 20:33 ` Stefan Beller
2014-12-30 21:15 ` Eric Sunshine
2014-12-30 7:46 ` Eric Sunshine
2014-12-30 8:42 ` Stefan Beller
2014-12-30 9:10 ` Eric Sunshine [this message]
2014-12-30 2:36 ` [PATCHv8 5/9] receive-pack.c: move transaction handling in a central place Stefan Beller
2014-12-30 8:36 ` Eric Sunshine
2014-12-30 18:45 ` Stefan Beller
2014-12-30 20:33 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 6/9] receive-pack.c: add execute_commands_atomic function Stefan Beller
2014-12-30 8:57 ` Eric Sunshine
2014-12-30 2:36 ` [PATCHv8 7/9] receive-pack.c: enable atomic push protocol support Stefan Beller
2014-12-30 2:36 ` [PATCHv8 8/9] push.c: add an --atomic argument Stefan Beller
2014-12-30 2:36 ` [PATCHv8 9/9] t5543-atomic-push.sh: add basic tests for atomic pushes Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQEfGj8dH+FFOR4UYbNgovhFy_pP8szSpS+0MyNdOvJrw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=ronniesahlberg@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).