From: Eric Sunshine <sunshine@sunshineco.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: chainlint test failing on Linux sparc64
Date: Mon, 20 May 2024 05:36:35 -0400 [thread overview]
Message-ID: <CAPig+cQL73gVDDSH_=8Y6D0Pro58W1O2Rb-hettVcfZudXjOZQ@mail.gmail.com> (raw)
In-Reply-To: <bdbf99ae4d6e3669b3506a7d4a26730aa9cd0ed4.camel@physik.fu-berlin.de>
On Mon, May 20, 2024 at 5:04 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> Bisecting was successful and has lead me to this commit:
>
> d00113ec3474a1652a73c11695c7e7b5182d80a7 is the first bad commit
> Author: Eric Sunshine <sunshine@sunshineco.com>
> Date: Thu Sep 1 00:29:46 2022 +0000
> t/Makefile: apply chainlint.pl to existing self-tests
>
> Now that chainlint.pl is functional, take advantage of the existing
> chainlint self-tests to validate its operation. (While at it, stop
> validating chainlint.sed against the self-tests since it will soon be
> retired.)
That's the point at which chainlint.sed was replaced with
chainlint.pl. It also leads to the same supposition expressed earlier
that the "actual" file seems to be empty for some reason, perhaps
because one of the commands which creates it is failing somehow. At
that point in time, the creation command for "actual" in t/Makefile
was:
$(CHAINLINT) --emit-all '$(CHAINLINTTMP_SQ)'/tests | \
grep -v '^[ ]*$$' >'$(CHAINLINTTMP_SQ)'/actual && \
which uses `grep` rather than the `sed` used in the present-day
t/Makefile. This may imply that Perl is somehow suspect or that
PERL_PATH or PERL_PATH_SQ in t/Makefile are incorrectly set, or that
t/chainlint.pl itself is not generating any output for some reason.
After running:
cd t
make check-chainlint
what is the output of:
ls -l chainlinttmp
For me the output using the latest "master" branch is:
% ls -l chainlinttmp
-rw------- 1 me me 14797 May 20 05:26 actual
-rw------- 1 me me 14797 May 20 05:26 expect
-rw------- 1 me me 15086 May 20 05:26 tests
My suspicion is that "actual" will have size 0 for you. If that's the
case, I'd suggest running the commands from the "check-chainlint"
target in t/Makefile manually one at a time to see if you can figure
out which is failing. For instance:
% ./chainlint.pl --emit-all chainlinttmp/tests
If that produces output, then that's a good sign. Try capturing that
output and feeding it to the `sed` command:
% ./chainlint.pl --emit-all chainlinttmp/tests >lint.out
% sed -e 's/^[1-9][0-9]* //' lint.out
If that produces output, then something else is going wrong (such as
PERL_PATH or PERL_PATH_SQ being incorrect).
next prev parent reply other threads:[~2024-05-20 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 7:56 chainlint test failing on Linux sparc64 John Paul Adrian Glaubitz
2024-05-20 8:21 ` Eric Sunshine
2024-05-20 8:24 ` John Paul Adrian Glaubitz
2024-05-20 9:04 ` John Paul Adrian Glaubitz
2024-05-20 9:36 ` Eric Sunshine [this message]
2024-05-20 9:56 ` John Paul Adrian Glaubitz
2024-05-20 9:58 ` Eric Sunshine
2024-05-20 10:02 ` John Paul Adrian Glaubitz
2024-05-20 11:02 ` John Paul Adrian Glaubitz
2024-05-20 16:04 ` Junio C Hamano
2024-05-20 16:07 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQL73gVDDSH_=8Y6D0Pro58W1O2Rb-hettVcfZudXjOZQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).