From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Pranit Bauva" <pranit.bauva@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH v16 0/7] config commit verbose
Date: Fri, 6 May 2016 01:30:45 -0400 [thread overview]
Message-ID: <CAPig+cQO3W4WthHstrVFWziU2RAuNyEzeQwBEyDXG8dghRjECQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq7ff8b99q.fsf@gitster.mtv.corp.google.com>
On Thu, May 5, 2016 at 3:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Pranit Bauva <pranit.bauva@gmail.com> writes:
>> This series of patches add a configuration variable for verbose in
>> git-commit.
>>
>> Changes wrt v15:
>> * Remove the previous patch 7/7 and split the tests. Include one in
>> initial patch 6/7. The other one is introduced in a separate commit
>> after 4/7.
>> * Include tests in patch 3/6 for --no-quiet without -q, multiple verbose,
>> --no-verbose with -v as suggested by Eric Sunshine
>
> Thanks for a pleasant read. Modulo minor readability nits I sent
> separately on 7/7, this looked good.
Agreed, this version was a more pleasant and coherent read than previous ones.
Considering that this series is already at v16 and the 7/7 review
comments were very minor, I'd be fine seeing this series land as-is,
rather than expecting v17.
next prev parent reply other threads:[~2016-05-06 5:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 20:03 [PATCH v15 1/7] t0040-test-parse-options.sh: fix style issues Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 2/7] test-parse-options: print quiet as integer Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 3/7] t0040-parse-options: improve test coverage Pranit Bauva
2016-05-04 8:36 ` Eric Sunshine
2016-05-05 4:46 ` Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 4/7] parse-options.c: make OPTION_COUNTUP respect "unspecified" values Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 5/7] t7507-commit-verbose: improve test coverage by testing number of diffs Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 6/7] commit: add a commit.verbose config variable Pranit Bauva
2016-04-30 20:03 ` [PATCH v15 7/7] t/t7507: tests for broken behavior of status Pranit Bauva
2016-05-02 23:07 ` Junio C Hamano
2016-05-03 3:39 ` Pranit Bauva
2016-05-03 5:12 ` Eric Sunshine
2016-05-03 6:42 ` Pranit Bauva
2016-05-03 6:49 ` Eric Sunshine
2016-05-03 9:18 ` Pranit Bauva
2016-05-03 16:17 ` Eric Sunshine
2016-05-03 16:18 ` Pranit Bauva
2016-05-03 15:47 ` Junio C Hamano
2016-05-05 9:49 ` [PATCH v16 0/7] config commit verbose Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 1/7] t0040-test-parse-options.sh: fix style issues Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 2/7] test-parse-options: print quiet as integer Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 3/7] t0040-parse-options: improve test coverage Pranit Bauva
2016-05-05 9:49 ` [PATCH v16 4/7] t/t7507: " Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 5/7] parse-options.c: make OPTION_COUNTUP respect "unspecified" values Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 6/7] t7507-commit-verbose: improve test coverage by testing number of diffs Pranit Bauva
2016-05-05 9:50 ` [PATCH v16 7/7] commit: add a commit.verbose config variable Pranit Bauva
2016-05-05 19:14 ` Junio C Hamano
2016-05-06 5:05 ` Pranit Bauva
2016-05-06 6:40 ` Pranit Bauva
2016-05-06 5:07 ` Eric Sunshine
2016-05-05 19:21 ` [PATCH v16 0/7] config commit verbose Junio C Hamano
2016-05-05 21:50 ` [PATCH 0/3] test-parse-options update Junio C Hamano
2016-05-05 21:50 ` [PATCH 1/3] test-parse-options: fix output when callback option fails Junio C Hamano
2016-05-05 21:50 ` [PATCH 2/3] test-parse-options: hold output in a strbuf Junio C Hamano
2016-05-05 21:50 ` [PATCH 3/3] test-parse-options: --expect=<string> option to simplify tests Junio C Hamano
2016-05-06 0:41 ` Stefan Beller
2016-05-06 1:27 ` Eric Sunshine
2016-05-06 2:57 ` Junio C Hamano
2016-05-06 5:51 ` Stefan Beller
2016-05-06 7:18 ` Junio C Hamano
2016-05-06 17:34 ` Junio C Hamano
2016-05-06 18:00 ` [PATCH] t0040: remove unused test helpers Junio C Hamano
2016-05-06 5:30 ` Eric Sunshine [this message]
2016-05-06 14:20 ` [PATCH v16 0/7] config commit verbose SZEDER Gábor
2016-05-06 15:33 ` Junio C Hamano
2016-05-07 5:32 ` Jeff King
2016-05-07 19:28 ` Ævar Arnfjörð Bjarmason
2016-05-08 18:48 ` Junio C Hamano
2016-05-09 14:28 ` Jeff King
2016-05-09 16:01 ` Junio C Hamano
[not found] ` <CACBZZX5ssO2EiuxR7wotGowMaPhtioaJVSDpQDUwUkv1rLJJWw@mail.gmail.com>
2016-05-06 16:16 ` Pranit Bauva
2016-05-06 19:47 ` Ævar Arnfjörð Bjarmason
2016-05-06 20:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQO3W4WthHstrVFWziU2RAuNyEzeQwBEyDXG8dghRjECQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pranit.bauva@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).