git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Peter Dave Hello <hsu@peterdavehello.org>
Cc: Git List <git@vger.kernel.org>
Subject: Re: contrib/diff-highlight: stop hard-coding perl location
Date: Mon, 22 Feb 2016 02:13:23 -0500	[thread overview]
Message-ID: <CAPig+cQp9H4K2D88bVxRRnwD_rY-8hROzVOp6aBCp9Y=Y6HwUA@mail.gmail.com> (raw)
In-Reply-To: <CA+boQ6bCH35hu9GfQY_P5bNZCdJ8Knr8zQ+S41RGF0z-JamVgw@mail.gmail.com>

[please don't top-post on this list]

On Mon, Feb 22, 2016 at 1:49 AM, Peter Dave Hello
<hsu@peterdavehello.org> wrote:
> Thank you, is there anything I should do? Or I should just wait?

Best is to wait for other review comments, particularly from Junio.
Reviewers work at their own pace as time permits, so don't be
surprised if it takes days or a week or more. If you don't hear back
from Junio after a week or two, and if you don't see that he has
silently picked it up in his "pu" branch and don't see mention of it
in Junio's "What's cooking" email after that time, then it can be
helpful to send a reminder about the patch to the list.

> Best,
> Peter
>
> 2016/2/22 下午1:56於 "Eric Sunshine" <sunshine@sunshineco.com>寫道:
>>
>> On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello
>> <hsu@peterdavehello.org> wrote:
>> > From: Peter Dave Hello <hsu@peterdavehello.org>
>> >
>> > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`,
>> > the util "env" can help located the "perl",
>> > so that it can work on FreeBSD and other platforms.
>> >
>> > Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
>>
>> Better, thanks.
>>
>> > ---
>> >  contrib/diff-highlight/diff-highlight | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/contrib/diff-highlight/diff-highlight
>> > b/contrib/diff-highlight/diff-highlight
>> > index ffefc31..b57b0fd 100755
>> > --- a/contrib/diff-highlight/diff-highlight
>> > +++ b/contrib/diff-highlight/diff-highlight
>> > @@ -1,4 +1,4 @@
>> > -#!/usr/bin/perl
>> > +#!/usr/bin/env perl
>> >
>> >  use 5.008;
>> >  use warnings FATAL => 'all';
>

      reply	other threads:[~2016-02-22  7:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22  5:54 contrib/diff-highlight: stop hard-coding perl location Peter Dave Hello
2016-02-22  5:56 ` Eric Sunshine
2016-02-22  6:49   ` Peter Dave Hello
2016-02-22  7:13     ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cQp9H4K2D88bVxRRnwD_rY-8hROzVOp6aBCp9Y=Y6HwUA@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=hsu@peterdavehello.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).